[HOLD for payment 2024-07-17] Wallet - Error page overlaps with device status bar

m-natarajan commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

issue found when validating #44628 Version Number: 9.0.4-0 Reproducible in staging?: y Reproducible in production?: no If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

Launch New Expensify app.
Go to Account settings > Wallet.
Click Enable Wallet.
Log in to Wells Fargo.
Proceed to idology sections.
Answer all idology questions incorrectly.

Expected Result:

The error page will not overlap with device status bar.

Actual Result:

The error page overlaps with device status bar.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/38435837/9b496f8d-093f-4bad-abb7-245307c8eba9

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 3 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

m-natarajan commented 3 months ago

@hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

m-natarajan commented 3 months ago

We think that this bug might be related to #vip-vsb

gijoe0295 commented 3 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error page overlaps with device status bar.

What is the root cause of that problem?

We're missing ScreenWrapper:

https://github.com/Expensify/App/blob/423544d96694e9bff96f9f3266ccf0c5dd64e47e/src/pages/EnablePayments/EnablePayments.tsx#L41-L47

What changes do you think we should make in order to solve the problem?

Wrap ScreenWrapper over the above snippet.

koko57 commented 3 months ago

as I'm the author of the PR I would like to fix this regression

hayata-suenaga commented 3 months ago

@koko57, thank you. please let me know when you raise a PR 🙇

koko57 commented 3 months ago

@hayata-suenaga PR raised: https://github.com/Expensify/App/pull/44809

hayata-suenaga commented 3 months ago

Thank you! taking a look now

mountiny commented 3 months ago

This was CPed and PR is pending verification

melvin-bot[bot] commented 2 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 2 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.5-13 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/44809

If no regressions arise, payment will be issued on 2024-07-17. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@koko57 does not require payment (Contractor)

melvin-bot[bot] commented 2 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@koko57] Determine if we should create a regression test for this bug.
[ ] [@koko57] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

hoangzinh commented 2 months ago

@hayata-suenaga can you help to assign me to this issue? I helped to review the PR https://github.com/Expensify/App/pull/44809. Thank you.

melvin-bot[bot] commented 2 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.6-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/44809

If no regressions arise, payment will be issued on 2024-07-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@hoangzinh requires payment (Needs manual offer from BZ)
@koko57 does not require payment (Contractor)

melvin-bot[bot] commented 2 months ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@hoangzinh] Determine if we should create a regression test for this bug.
[ ] [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

trjExpensify commented 2 months ago

Checklist time!

hoangzinh commented 2 months ago

BugZero Checklist:

[x] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/42589
[x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42589/files#r1684260094
[x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[x] Determine if we should create a regression test for this bug: ⛔ No I think it's a small UI issue.

melvin-bot[bot] commented 2 months ago

@hoangzinh, @trjExpensify, @koko57, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

trjExpensify commented 2 months ago

Thanks! Confirming payments as follows:

$250 to @hoangzinh for the C+ review

Offer sent!

hoangzinh commented 2 months ago

Accepted. Thanks @trjExpensify

trjExpensify commented 2 months ago

Paid, closing!

Expensify / App