search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.12k stars 2.61k forks source link

Sage Intacct - Back button on workspace editor returns to Accounting page again #44813

Open izarutskaya opened 3 days ago

izarutskaya commented 3 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.4-0 Reproducible in staging?: Y Reproducible in production?: N Found when executing PR : https://github.com/Expensify/App/pull/43661 Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  1. Go to staging.new.expensify.com
  2. Go to another workspace that is not connected to Sage Intacct.
  3. Go to Accounting.
  4. Tap Connect next to Sage Intacct.
  5. Select Reuse existing connection.
  6. Tap on the workspace that is connected to Sage Intacct.
  7. Tap back button on the top left.
  8. Tap back button again.

Expected Result:

App will return to workspace list.

Actual Result:

App returns to Accounting page again (from Step 3).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/fddb9791-012f-42ae-8f05-e980a811f600

View all open jobs on GitHub

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 3 days ago

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 3 days ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
izarutskaya commented 3 days ago

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

izarutskaya commented 3 days ago

We think this issue might be related to the #collect project.

lakchote commented 3 days ago

cc @SzymczakJ since you've worked on https://github.com/Expensify/App/pull/43661

lakchote commented 3 days ago

I'd say it's not a blocker, as it's an edge case and it doesn't affect core functionality.

Plus, it's behind the intacctOnNewExpensify beta.

twisterdotcom commented 3 days ago

@SzymczakJ let us know if you want to take this. Otherwise we can open it up.

SzymczakJ commented 3 days ago

Implementation of this feature is in progress and "Reuse existing connection" screen is still not ready. Right now I'm working on follow-up PR for Sage Intacct and I'll fix this navigation bug in it. Is it okay with you? Assign me to this one so I can notify you to retest when my fix is merged 😃

hungvu193 commented 3 days ago

@lakchote Please assign me as well since I worked with @SzymczakJ in the offending PR