search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.16k stars 2.65k forks source link

[HOLD for payment 2024-07-17] Categories - The subtitle under "Members must categorize all expenses" contains "undefined" #44826

Closed kavimuru closed 1 week ago

kavimuru commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.4-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Categories.
  3. Click Settings.

Expected Result:

The subtitle under "Members must categorize all expenses" will not contain "undefined".

Actual Result:

The subtitle under "Members must categorize all expenses" contains "undefined". "Require a category on every expense in order to export to undefined."

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/43996225/468cfd62-208b-4aba-8cb3-fa3536e5f7bc

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @zanyrenney
melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 3 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
kavimuru commented 3 weeks ago

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Krishna2323 commented 3 weeks ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories - The subtitle under "Members must categorize all expenses" contains "undefined"

What is the root cause of that problem?

Undefined is shown when current policy does not have any connection. https://github.com/Expensify/App/blob/27847125200c0b69d3371b75bc85923f4fcf6705/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx#L27-L29

What changes do you think we should make in order to solve the problem?

Show a different subtitle when policy does not have any connection. We can create one or use categories.subtitle. Or we can just make the subtitle empty when there is no connection. The same should be done on other pages where we use PolicyUtils.getCurrentConnectionName(policy)

What alternative solutions did you explore? (Optional)

tgolen commented 3 weeks ago

@Krishna2323 I think we should use categories.requiresCategory ("Members must categorize all expenses") if there is no connection. What do you think? Seems like it makes sense to me.

melvin-bot[bot] commented 3 weeks ago

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

Krishna2323 commented 3 weeks ago

@tgolen, ~yes we can use that instead, makes sense.~ workspace.categories.requiresCategory is already used as title, I think we just need to remove the subtitle if there is no connection.

allgandalf commented 3 weeks ago

This is a deploy blocker, what is the offending PR @Krishna2323 ?

Krishna2323 commented 3 weeks ago

@allgandalf https://github.com/Expensify/App/pull/44664

tgolen commented 3 weeks ago

we just need to remove the subtitle if there is no connection.

Perfect, this is fine. Thanks! I'll assign you

allgandalf commented 3 weeks ago

ummm, I agree with @Krishna2323, we should not show any subtitle if we do not have any connection, @tgolen what do you think ?

allgandalf commented 3 weeks ago

@Krishna2323 , will you be able to come up with a PR now? t

Krishna2323 commented 3 weeks ago

@allgandalf, will be ready in next 2 hours.

Krishna2323 commented 3 weeks ago

@allgandalf, PR ready for review ^

mountiny commented 2 weeks ago

This was CPed and the PR is pending validation in staging

allgandalf commented 2 weeks ago

@mountiny can you update the title to hold for payment please

melvin-bot[bot] commented 2 weeks ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 2 weeks ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.5-13 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 2 weeks ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.6-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 1 week ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

allgandalf commented 1 week ago

Regression Test Proposal

  1. Select a workspace with an integration from workspace page > Categories
  2. Click Settings > Verify Require a category on every expense... is shown
  3. Select a workspace with no integration from workspace page > Categories
  4. Click Settings > Verify no subtitle is shown below switch

Do we agree 👍 or 👎

allgandalf commented 1 week ago

[!NOTE] @zanyrenney , this is ready for payment, the payment date is wrong, idk why melvin is acting so weird lately, so the payment date was actually 15th, can you pay this out please, thanks

zanyrenney commented 1 week ago

okay thanks @allgandalf

zanyrenney commented 1 week ago

@allgandalf @Krishna2323 please accept job offer via upwork!

zanyrenney commented 1 week ago

https://www.upwork.com/jobs/~01bb053c1f7f26c8bd

allgandalf commented 1 week ago

Applied from my side 👍

zanyrenney commented 1 week ago

payment summary

@Krishna2323 requires payment (Needs manual offer from BZ) - paid $250 via Upwork @allgandalf requires payment (Needs manual offer from BZ) - paid $250 via Upwork

zanyrenney commented 1 week ago

payments complete, and regression test requested!