[$250] Report field - Different system message for report field edit in expense report and LHN

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.4-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory around https://expensify.testrail.io/index.php?/tests/view/4695978 Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

Precondition:

• User has created a Text type report field from Report fields section on ND.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit two expenses.
4. Click on the text field.
5. Enter text and save it.
6. Revisit the expense report.

Expected Result:

The system message for report field edit will be consistent in expense report and LHN.

Actual Result:

The system message for report field edit is different in expense report and LHN. In expense report, it shows "changed Text field from undefined to x." In LHN, it shows "modified field 'Text field'. New value is 'x' (previously '').

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/43996225/796620e5-bf65-4070-be7d-36b05e73d6fd

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d8549f82fbcaeb27
• Upwork Job ID: 1808920292412937149
• Last Price Increase: 2024-07-04

Issue Owner

Current Issue Owner: @ZhenjaHorbach

[melvin-bot[bot]]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[arosiclair]

We can demote this per this thread (report fields are behind a beta).

[arosiclair]

Pretty sure this can be fixed externally

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01d8549f82fbcaeb27

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[ZhenjaHorbach]

@nkdengineer Thank you for your proposal ! I like your main solution and I agree that we should use the same condition and function to display text as we do in expense report for LHN

🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Current assignee @arosiclair is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[parasharrajat]

We should solve this issue holistically. There are many old actions and we should solve them all. We are trying to solve a similar issue here https://github.com/Expensify/App/issues/44817.

@kavimuru Could you please ping us on https://github.com/Expensify/App/issues/44817 when you find such issue?

[arosiclair]

This seems to be stemming from https://github.com/Expensify/App/pull/43079 and the system messages project. The proposal LGTM for fixing last message text in the LHN. @deetergp you mind taking a look before I hire?

[trjExpensify]

I agree with @parasharrajat, we should take care of this as one. @BrtqKr is working on a draftPR for the other issue.

[parasharrajat]

I am fine with @nkdengineer solving this issue. We can merge the context menu changes into that PR from @BrtqKr's draft PR.

[BrtqKr]

This could be solved with my PR, since the OldDot message condition covers CHANGEFIELD types as well. I'm only concerned about the messages from the old dot having NewDot type for modification assigned instead.