"Enable wallet" button still shows for payment receiver even after payment is cancelled after 30 days

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: Reproducible in staging?: Needs Reproduction (Unable to reproduce as "I don't have any pending report with over 30 days") Reproducible in production?: Needs Reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @shawnborton Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1720018780579139

Action Performed:

1. As user B without wallet enabled submit expense to user A
2. As user A Approve the report and pay

   Expected Result:

   For User B the payment auto cancelled after 30 days and no option to enable the wallet

   Actual Result:

   "Enable wallet" button still shows for payment receiver on the report

   Workaround:

   Unknown

   Platforms:

   Which of our officially supported platforms is this issue occurring on?

   • [ ] Android: Native
   • [ ] Android: mWeb Chrome
   • [ ] iOS: Native
   • [ ] iOS: mWeb Safari
   • [x] MacOS: Chrome / Safari
   • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[puneetlath]

Asked for clarification here: https://expensify.slack.com/archives/C049HHMV9SM/p1720476086833019?thread_ts=1720018780.579139&cid=C049HHMV9SM

[melvin-bot[bot]]

@puneetlath Whoops! This issue is 2 days overdue. Let's get this updated quick!

[puneetlath]

Working on figuring out how to repro this.

[melvin-bot[bot]]

@puneetlath this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[puneetlath]

I'm thinking we should just close this for now as we're not focused on #vip-split and there's not really anyone to experience this. We can/should fix it when we re-prioritize #vip-split.

@shawnborton reopen if you disagree!

[shawnborton]

I think that's fair. My DM with this user is in a weird state because I basically can't get rid of the failed "Send money" - each time I try to delete the expense, I get an error. Anyways, I recognize no one is running into this right now so we can definitely keep it closed, just noting that we definitely have even more problems and issues we need to address with the failed Send money flow here.

[puneetlath]

Oh interesting. Is the cause of the error the same issue as what's reported here? If so, I can see the argument for fixing it.

[shawnborton]

I'm not sure if the cause is the same... though I guess they are both related in that they are bugs related to the expired Send money case?

So the two bugs:

Sender: if you send someone money, and they don't enable a wallet after 30 days, the payment technically cancels but you can't actually delete the expense. What's even weirder is that we then show a "Pay with Expensify" button to the Sender after the 30 days pass...

Here's what happens when you delete: you get an infinite loading loop, which after I refresh the page manually, you can see the RBR error show up:

https://github.com/user-attachments/assets/3f07a0ff-e135-4329-9200-0a166c96e9f4

---

Receiver: the IOU is stuck with a GBR to enable the wallet:

But it is past the 30 days and the money request has been cancelled: