search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.14k stars 2.63k forks source link

Workspace - Not here page displayed when navigate to workspace via join link #44845

Open lanitochka17 opened 1 week ago

lanitochka17 commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.4.0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - internal Team

Issue found when executing PR https://github.com/Expensify/App/pull/44716

Action Performed:

precondition: as user A copy a join link of a workspace where user B is not a member

  1. Open the app and log in as user B
  2. Tap the copied workspace join link, e.g. https://staging.new.expensify.com/settings/workspaces/D047C9A2ABF7DFA3/join?email=applausetester+0703pm@applause.expensifail.com
  3. Tap the back icon

Expected Result:

User is navigated to the workspace and after taping the back icon is returned to the report where the link was shared

Actual Result:

The "Hmm, not here page " is displayed when tapping the workspace join link and when go back to the report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/b6d5aff1-41bd-48e3-8e74-2d770915e062

View all open jobs on GitHub

bernhardoj commented 1 week ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not found page is shown when going back from workspace list page after navigate to the workspace join link.

What is the root cause of that problem?

When we open the join link page, we call navigateAfterJoinRequest which navigates to ROUTES.ALL_SETTINGS and ROUTES.SETTINGS_WORKSPACES https://github.com/Expensify/App/blob/ce5ae736eccd5180f50e47e21db047dd33b90a43/src/libs/navigateAfterJoinRequest/index.ts#L4-L8

However, ROUTES.ALL_SETTINGS isn't being used anymore. It's the old route name for the settings page, so there will be a not found page in the nav stack.

[ROUTES.ALL_SETTINGS (not found), ROUTES.SETTINGS_WORKSPACES]

Going back from the workspace list page will shows the not found page.

What changes do you think we should make in order to solve the problem?

Change the route to ROUTES.SETTINGS and remove ROUTES.ALL_SETTINGS const. Doing this, the user will be navigated to the settings bottom tab page and then to the workspace list page.

OR

We can just remove the navigation to the Settings page.

melvin-bot[bot] commented 1 week ago

Huh... This is 4 days overdue. Who can take care of this?

c3024 commented 6 days ago

@lanitochka17 No BZ member assigned here. Please re-add Bug label.

melvin-bot[bot] commented 5 days ago

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 5 days ago

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

alexpensify commented 1 day ago

Ok, I'll add it to my testing list.