[HOLD for payment 2024-08-07] [$250] Login – Please enter an email or phone number is not is not displayed in Spanish

lanitochka17 commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.4.0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): gocemate+a523@gmail.com Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Scroll down the login page
Change the language to Spanish

Expected Result:

"Please enter an email or phone number" error message should be displayed in Spanish

Actual Result:

"Please enter an email or phone number" error message is not displayed in Spanish

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/e28ac091-2a72-4559-b93a-1e5a59783d92

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015ecfe6dbe2a9cae6
Upwork Job ID: 1810338171865148259
Last Price Increase: 2024-07-15
Automatic offers:

alitoshmatov | Reviewer | 103143197
ShridharGoel | Contributor | 103143199

Issue Owner

Current Issue Owner: @muttmuure

alitoshmatov commented 2 months ago

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/42970
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42970/files#r1712560713
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
Determine if we should create a regression test for this bug. No need

melvin-bot[bot] commented 2 months ago

@luacmartins, @muttmuure, @alitoshmatov, @Krishna2323 Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] commented 2 months ago

@luacmartins, @muttmuure, @alitoshmatov, @Krishna2323 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] commented 2 months ago

@luacmartins, @muttmuure, @alitoshmatov, @Krishna2323 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

alitoshmatov commented 2 months ago

This one is ready for payment @muttmuure

muttmuure commented 2 months ago

$250 - @alitoshmatov (paid)

Krishna2323 commented 2 months ago

@muttmuure, we decided to split the bounty between me and @ShridharGoel. Could you please create new offers for both of us, if possible?

muttmuure commented 2 months ago

Will fix this tomorrow

muttmuure commented 2 months ago

So just to clarify - is this $125 to you @Krishna2323 and $125 to @ShridharGoel ?

Krishna2323 commented 2 months ago

So just to clarify - is this $125 to you @Krishna2323 and $125 to @ShridharGoel ?

Yes, correct.

melvin-bot[bot] commented 1 month ago

@luacmartins, @muttmuure, @alitoshmatov, @Krishna2323 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!