Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.28k stars 2.71k forks source link

Subscription - "Request refund" button is missing from the subscription page #44899

Closed lanitochka17 closed 1 month ago

lanitochka17 commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.4-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Issue found when executing PR https://github.com/Expensify/App/pull/44138

Action Performed:

Precondition: Have a Collest workspace and enabled subscription with a Gmail account

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with the Gmail account
  3. Navigate to https://staging.new.expensify.com/settings/subscription

Expected Result:

"Request refund" button should be available

Actual Result:

"Request refund" button is missing from the subscription page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/38103576-34b1-4cc2-b1a3-b444f05dc4ab

RRRBBB

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 1 month ago

@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

RachCHopkins commented 1 month ago

@lanitochka17 I'm not sure about this one. But I do see that request refund is available in Expensify Classic, so if there should be parity on this in New Expensify, then yes it is a bug:

image

trjExpensify commented 1 month ago

We had a similar report with a retry payment function over here: https://github.com/Expensify/App/issues/44917

I commented on that issue, but it would be good to figure out if this is personal/corporate karma related @MitchExpensify.

Said differently, from the billing history above, $4.99 isn't a collect or control plan subscription.

RachCHopkins commented 1 month ago

Thanks @trjExpensify, personally I didn't think anyone could request refunds on these, but if the button is in OldDot it should be in NewDot. Unless it shouldn't be in OldDot, which is kind of what I am leaning towards.

trjExpensify commented 1 month ago

Yeah, I'm not 100%. Isn't that managed through Apple and IAP.

RachCHopkins commented 1 month ago

I only know from a Concierge Ops point of view:

  1. Monthly individual subscriptions are paid in advance - when a user cancels, we turn off the SmartScans at the end of the period. Refund requests usually come in via Concierge and we process them via supportal
  2. Karma subscriptions align with the billing period, and refund requests come in via Concierge, we process them directly in Stripe.

I've never known there to be a Request Refund button for either.

trjExpensify commented 1 month ago

That makes sense to me too. 👍

RachCHopkins commented 1 month ago

Ok so @trjExpensify does this mean it's actually an OldDot issue / Internal?

trjExpensify commented 1 month ago

Yeah, so a couple of things:

  1. We aren't showing anything to do with individual subscription billing in NewDot yet, that subset of customers aren't a focus right now. So this button shouldn't appear in NewDot for an individual subscription at this point regardless.

  2. As for OldDot, I'm not sure we've concluded which subscription types we show the button for. I took a cursory look, and I found this for the isEligibleForRefund query. TYPE_MONTHLY & TYPE_YEARLY seem like they are collect/control related billingTypes when looking to corroborate that here. But that might be only for the automated billing refund eligibility, and not simply allowing them to request a refund (and Conci handle the request manually).

RachCHopkins commented 1 month ago

@trjExpensify in that case should I close this and we revisit it when we get to that stage in NewDot?

trjExpensify commented 1 month ago

Yep, sounds good!