Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.2k stars 2.68k forks source link

[$250] Thread - The message "left the chat" is repeated endlessly in the deleted message thread #44918

Closed lanitochka17 closed 1 week ago

lanitochka17 commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.4-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4696971 Email or phone of affected tester (no customers): sustinov@applausemail.com Issue reported by: Applause - Internal Team

Action Performed:

  1. Open https://staging.new.expensify.com/.
  2. Log in with account A
  3. In incognito mode, log in to account B
  4. Under user A, send a manual IOU to user B
  5. Create a thread in this IOU
  6. Send several messages in the IOU thread
  7. Delete the IOU
  8. Under user B, open to the deleted IOU thread
  9. User B: Click on the "Join" button
  10. User B: Click on the three dots in the header
  11. User B: Click on "Leave"
  12. Under user A, open and refresh the deleted IOU thread

Expected Result:

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/0df28678-c6e9-4bfd-b155-4fa3b2f3985e

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01565b5a941ea6d86a
  • Upwork Job ID: 1812813116893292566
  • Last Price Increase: 2024-07-22
Issue OwnerCurrent Issue Owner: @s77rt
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 1 month ago

@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

melvin-bot[bot] commented 3 weeks ago

@muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 3 weeks ago

@muttmuure Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] commented 3 weeks ago

@muttmuure Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~01565b5a941ea6d86a

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

muttmuure commented 2 weeks ago

Not overdue

melvin-bot[bot] commented 2 weeks ago

@s77rt, @muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

s77rt commented 2 weeks ago

Still looking for proposals

melvin-bot[bot] commented 2 weeks ago

@s77rt @muttmuure this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

s77rt commented 2 weeks ago

Same ^

hannojg commented 1 week ago

Hi, I am Hanno from Margelo, an expert agency and I can work on this issue.

s77rt commented 1 week ago

@hannojg Thanks for taking this. Looking forward for your input 🚀

hannojg commented 1 week ago

Hm, I can't reproduce on the current main branch - also the UI has changed a bit since then:

https://github.com/user-attachments/assets/33188faf-67d4-4acf-9713-70f88c0fd639

Or did I do something wrong during the reproduction?

Testing on staging now …

hannojg commented 1 week ago

Can't really reproduce on staging either 🤔

https://github.com/user-attachments/assets/5a3bc6e8-6b63-42db-b3be-a3a9cd0ab9eb

melvin-bot[bot] commented 1 week ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

s77rt commented 1 week ago

I can't reproduce either. The "left the chat" message is shown once

https://github.com/user-attachments/assets/f7ea0e3b-0980-44c7-9e72-781d243f9766

muttmuure commented 1 week ago

If it's not reproducible, let's close it.