Closed lanitochka17 closed 1 month ago
Triggered auto assignment to @JmillsExpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Blank background displayed when redirected from desktop to connect bank
After clicking the link from desktop, the link will be open to web. We need to logout the previous user
Now the web is redirect to bank-account/new
. -> the routes are bottom and right navigator.
Then the current user is login and setUpPoliciesAndNavigate
is called.
bank-account/new?policyID=
-> RightNavigator is added to routes without central navigatorWe don't need to call goBack
in
We added it because We must call goBack() to remove the /transition route from history
. But we already have the logic to goBack in logoutPreviousUser so we don't need it anymore.
@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
I think this is technically #wave-collect since it's the VBBA flow. Opening up to external.
Job added to Upwork: https://www.upwork.com/jobs/~010505fec65584f108
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External
)
@dominictb Thanks for your proposal!
The following condition is true https://github.com/Expensify/App/blob/83be857a0db2dfd3e3f8ba241a5742898fee3462/src/libs/actions/App.ts#L424 if and only if clicking connect bank from desktop right? https://github.com/Expensify/App/blob/83be857a0db2dfd3e3f8ba241a5742898fee3462/src/pages/ReimbursementAccount/BankAccountStep.tsx#L137
If so, then I think it'll be safe to fix it by removing Navigation.goBack();
here
https://github.com/Expensify/App/blob/83be857a0db2dfd3e3f8ba241a5742898fee3462/src/libs/actions/App.ts#L428-L429
if and only if clicking connect bank from desktop right?
Yes
If so, then I think it'll be safe to fix it by removing Navigation.goBack(); here
It works by my side. What about you?
It works by my side. What about you?
@dominictb However, it doesnβt work on my end
https://github.com/Expensify/App/assets/117511920/f4c0c22f-e530-4365-81eb-2abbed275c15
@eh2077 I see you're using production link, right? Can you pls apply the solution and run dev?
@dominictb I opened the link from dev desktop. How to let it open dev domain on browser?
@dominictb It works for me too if I hard-coded the url to dev domain.
https://github.com/user-attachments/assets/375d1ad5-4a98-4bf7-b834-073fc4f877b8
@dominictb 's proposal looks good to me.
πππ C+ reviewed
Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
@thienlnam What do you think about my proposal above? Thanks
Not overdue waiting for @thienlnam 's review
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
π£ @eh2077 π An offer has been automatically sent to your Upwork account for the Reviewer role π Thanks for contributing to the Expensify app!
π£ @dominictb π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
This should be ready for payment, no @JmillsExpensify @thienlnam?
Yeah, looks like the automation did not work here
@JmillsExpensify @thienlnam @eh2077 @dominictb this issue is now 4 weeks old, please consider:
Thanks!
@eh2077 Can you complete the regression test here so we can close this out?
Payment summary:
Contributor paid via Upwork. @eh2077 mind completing the checklist so that I can process your payment as well?
Contributor paid and regression test created. Closing.
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.4-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+shch1@applause.expensifail.com Issue reported by: Applause - Internal Team
Issue found when executing PR https://github.com/Expensify/App/pull/44517
Action Performed:
Expected Result:
Workspace chat should be displayed when redirected from desktop to connect bank
Actual Result:
Blank background displayed when redirected from desktop to connect bank
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/5a4b2dfe-eb1a-4474-90cd-704d38b14b62
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @JmillsExpensify