Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.44k stars 2.8k forks source link

[$250] Delay in showing LHN and not found page in report screen when switching between bottom tabs #44949

Closed mountiny closed 2 months ago

mountiny commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.5 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

Action Performed:

Break down in numbered steps

  1. Log into a heavy account
  2. Switch from Chats to Settings
  3. Switch back to Chats
  4. Repeat

Expected Result:

Describe what you think should've happened

There should be little to no delay when rendering the individual pages

Actual Result:

Describe what actually happened

Seems like there are some extra renders or we are waiting longer for rendering something

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Staging:

https://github.com/Expensify/App/assets/36083550/8be41bd2-ab38-4758-8834-ce6f0e8528fd

Production:

https://github.com/Expensify/App/assets/36083550/0ad0d8f1-6d24-4751-9698-d48e539050b7

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e0321979061e3e17
  • Upwork Job ID: 1810252490706554621
  • Last Price Increase: 2024-07-08
Issue OwnerCurrent Issue Owner: @ishpaul777
melvin-bot[bot] commented 3 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01e0321979061e3e17

melvin-bot[bot] commented 3 months ago

Current assignee @mountiny is eligible for the DeployBlockerCash assigner, not assigning anyone new.

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 3 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
Julesssss commented 3 months ago

After catching up on the discussion here, I lean towards not blocking on this.

For now we will continue, but if this ends up being the last blocker I will continue. It is a worse experience for large accounts, but not a huge deal IMO. But @mountiny, feel free to make a counterargument if I missed the context.

mountiny commented 3 months ago

I agree, seems like they did not find anything that would make the staging noticeably slower than production, it might have been caused by something else for me. There are already some PRs that should improve this

ishpaul777 commented 2 months ago

Awaiting proposals

mountiny commented 2 months ago

At this point, I am not sure if I am able to reproduce, have you been able to notice anything like this @ishpaul777 ?

ishpaul777 commented 2 months ago

Not reproducable 🎉

https://github.com/Expensify/App/assets/104348397/3c652ad0-4901-4227-89c0-092e8106fb11

isabelastisser commented 2 months ago

Thanks, team! Closing this.