Closed izarutskaya closed 1 month ago
Triggered auto assignment to @stitesExpensify (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
Triggered auto assignment to @lschurr (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
@lschurr I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
We think this issue might be related to the #collect project.
Production
Hi hi @stitesExpensify - Can you check on this and confirm if it's a deploy blocker? Do we need to add External here?
Checking
Job added to Upwork: https://www.upwork.com/jobs/~0166593468459204f3
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External
)
Commented here https://github.com/Expensify/App/pull/44229
All transactions are unapproved when a single transaction is unapproved.
The approve option is available on the expense report which will approve all the transactions, so it makes sense if unapprove will unapprove all transactions too. They both work on the expense report level, not on each transaction.
So, I think the real issue here is that the Unapprove option is shown on the transaction thread details page. That's because when we check whether the report is a money request report or not, we always pass the money request report itself, which is true for the transaction thread too. https://github.com/Expensify/App/blob/7b558ef7fb9908223d899b54ad3d0156bc8fcb81/src/pages/ReportDetailsPage.tsx#L202-L205
The moneyRequestReport
variable holds the parentx money request report of the transaction.
https://github.com/Expensify/App/blob/7b558ef7fb9908223d899b54ad3d0156bc8fcb81/src/pages/ReportDetailsPage.tsx#L184-L189
We should check for the current report instead of the moneyRequestReport
.
https://github.com/Expensify/App/blob/7b558ef7fb9908223d899b54ad3d0156bc8fcb81/src/pages/ReportDetailsPage.tsx#L202-L205
ReportUtils.isMoneyRequestReport(report) && ...
Thank @bernhardoj for the proposal. I’ll start reviewing it.
I’m still stuck when trying to approve an expense due to the requirement to add a payment card. I have tried a lot of test cards provided by stripe, bluesnap, plaid but none of them worked. @stitesExpensify, do you have documentation on how to bypass the “add payment card” step in a dev environment?
I don't think we need to block the backend on this!
@bernhardoj i agree with your assessment & proposed solution 👍 I'm already working on a PR to fix another blocker so I will test out your theory & implement it, if you don't mind (you'll be compensated for the solution if it works, of course)
Fix merged & CPing
Should be good now, IOUs are no longer Unapprovable 👍 tested in 9.0.5-6
👍
Keeping open so @bernhardoj can get paid for his solution here that I implemented in https://github.com/Expensify/App/pull/45049 (along with another small change) 🙏 - cc @lschurr
@Beamanator, @suneox, @lschurr, @stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@lschurr can you help us retest? This should have been fixed already
Yes, I'm a bit behind but can test tomorrow - @bernhardoj @suneox are you able to jump in and test this?
Tested on staging, the Unapprove button doesn't show on the transaction thread anymore 🎉
https://github.com/user-attachments/assets/2b08c4ed-0991-44f4-8b0a-ae96464062f1
Woop! Amazing. Is there a PR associated with this specific GH that requires payment or are we good to close?
PR was https://github.com/Expensify/App/pull/45049! But it fixed multiple issues FYI 🙏
Ok, so payment is being issued elsewhere? Or do we need to pay here @Beamanator?
@Beamanator @suneox @lschurr @stitesExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@lschurr I think it's just payment for @bernhardoj here via this comment.
Great, thanks!
Payment summary:
Requested in ND.
$250 approved for @bernhardoj
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.5-3 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): natnael.expensify+0a89fdndafadf@gmail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team
Action Performed:
Precondition: Create workspace > More features > Enable workflow > Enable Add approvals > Make yourself approver
Expected Result:
Only the unapproved report should be unapproved
Actual Result:
Both IOUs are unapproved
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/d19669f2-21cd-4e44-8a10-9f2ea11e20ea
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @lschurr