[Currency] Workspace - After changing workspace currency, approving, then unapproving an expense the amount updates not the currency

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.5-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a workspace and enable work flows and enable approvals
3. Submit an expense in the workspace chat
4. Go to workspace settings and change the currency
5. Go to workspace chat and open the submitted expense report
6. Click on the approve button on the header and observe the system message
7. Click on down arrow to the right of the title then click Unapprove

Expected Result:

Both the currency and the amount get updated to the correct one

Actual Result:

The amount gets updated to reflect the correct amount after conversion, but the currency still remains the same

Workaround:

Unnown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/686e0a36-0c9e-46e5-b361-bfc31e162676

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019897b64867377d98
• Upwork Job ID: 1813371632470305179
• Last Price Increase: 2024-10-16

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot[bot]]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[mallenexpensify]

Before the bug shows, this happens which I'm unsure about. The approved says ETB and the unapproved shows Br.

Earlier in the vid it shows ETB - Br as the default currency. Need to figure out why it's showing like this and if they're considered the same.

[mallenexpensify]

App crashed on me when I tried to repro, posted about here

• https://github.com/Expensify/App/issues/44410#issuecomment-2215861787

[melvin-bot[bot]]

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

@mallenexpensify Still overdue 6 days?! Let's take care of this!

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~019897b64867377d98

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[mallenexpensify]

@hungvu193 can you attempt reproduction? I don't think I was able to.

https://github.com/user-attachments/assets/1f1d39da-04c5-4731-aad1-cb42e7206339

[hungvu193]

@mallenexpensify Same here. @lanitochka17 can you still reproduce this one?

[mallenexpensify]

I threw retest-weekly, if QA isn't able to repro we'll close.

[melvin-bot[bot]]

@hungvu193 @mallenexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[lanitochka17]

Issue still reproducible when unapproving but when approving issue does not get reproducible.

https://github.com/user-attachments/assets/8628a2c7-2666-46dc-aadc-921ba46c94b4

[mallenexpensify]

@hungvu193 can you please test based on the vid above? It looks like I was able to repro

Assuming you are, I'll update the steps in OP then open this up for proposals

[hungvu193]

Sure I'll give it a try today

[hungvu193]

Ok, I can reproduce this one

[hungvu193]

I think this is BE issue, API returned wrong amount after being unapproved

[mallenexpensify]

@hungvu193 can you add 🎀 to assign an internal engineer to confirm it's backend? Thx

[hungvu193]

Sure.

🎀 👀 🎀

[melvin-bot[bot]]

Triggered auto assignment to @puneetlath, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

@puneetlath @hungvu193 @mallenexpensify this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[hungvu193]

Not overdue, this is BE issue

[puneetlath]

I agree it's a back-end issue. Added the hot-picks label and assigned to wave-collect.

[trjExpensify]

Unapprove is built in #wave-control, moving. CC: @Beamanator @garrettmknight

[mvtglobally]

Issue is reproducible during KI retests.

https://github.com/user-attachments/assets/87e039c2-888f-4676-b3e3-ebe82b10065a

[Beamanator]

I'm happy to take this on, but it would be great if we could clean this issue up a little bit 🙏

1. The issue title still mentions approving but we're mainly talking about unapproving now, right?
2. Do we have super reproducible steps? We still have the label Needs Reproduction so that makes me think that we don't yet?

[melvin-bot[bot]]

@Beamanator, @hungvu193, @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

Gotcha @Beamanator , title and OP updated. it was just this that needed to be added at the end of the steps

7. Click on down arrow to the right of the title then click Unapprove

I was able to reproduce just now

[melvin-bot[bot]]

@Beamanator, @hungvu193, @mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

[Beamanator]

ohhhh baby, i'll try to check this out today

[Beamanator]

planning to look this week

[Beamanator]

Merp haven't had time yet

[melvin-bot[bot]]

@Beamanator, @hungvu193, @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Beamanator]

this weeeeek

[melvin-bot[bot]]

@Beamanator, @hungvu193, @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Beamanator]

next weeeek 😳

[melvin-bot[bot]]

@Beamanator, @hungvu193, @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Beamanator]

still haven't had time :/

[Beamanator]

same, def this week

[Beamanator]

Ok sorry this took so long to get back to, but now that I'm trying to reproduce locally, I don't actually see the same bug happening, do you @mallenexpensify @hungvu193 ? If not, let's add retest-weekly to see if applause can reproduce. Here's what I'm seeing:

https://github.com/user-attachments/assets/ff1b6232-4f16-4f6c-a096-c4952371dbcc

[mallenexpensify]

Threw retest-weekly on it, bumped to weekly and made me owner. Thx for checking/testing Alex

[Beamanator]

Waiting for retest

[mallenexpensify]

Should be retested soon

[mallenexpensify]

Still waiting on retest

[mvtglobally]

Issue is reproducible during KI retests.

https://github.com/user-attachments/assets/36680729-4a6b-4c4b-a5d1-f00ae07356a2

[melvin-bot[bot]]

Upwork job price has been updated to $500

[mallenexpensify]

~Adding Help Wanted back and bumping to $500 to get 👀. I tried to repro yesterday and ran into another issue :/ Will test again soon, if/when needed~

Strike that... it's an internal issue, labeled as such and readded Hot Pick.

[mallenexpensify]

Updated title to inc. [Currency] Waiting to get picked up internally, it's on #expense so not a near term priority