[HOLD for payment 2024-08-02] [$250] Continue button is hidden behind keyboard on onboarding pages.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.5-5 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @rayane-djouah Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1720471428343119

Action Performed:

1. Create a new account.
2. Choose "manage my team expenses" purpose on the first onboarding page
3. Type Business name
4. Click continue
5. Type first name
6. Click continue

Expected Result:

The continue button move to the top with the keyboard when opening it

Actual Result:

The continue button is hidden behind the keyboard

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [X] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/38435837/9ae6de2b-8b8b-424d-9ce9-6f2d4e00a4d0

https://github.com/Expensify/App/assets/38435837/1325fbcf-464c-40b2-b870-ac2c9689e3ef

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ca1aa78c61096205
• Upwork Job ID: 1810702818116110090
• Last Price Increase: 2024-07-09
• Automatic offers:
• rayane-djouah | Contributor | 103050117
• nkdengineer | Contributor | 103118552

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot[bot]]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[m-natarajan]

@lschurr Issue reporter commented to assign this to him as he have context. I am not sure I can assign him or not, Can you please confirm?

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The continue button is hidden behind the keyboard

What is the root cause of that problem?

https://github.com/Expensify/App/blob/7b558ef7fb9908223d899b54ad3d0156bc8fcb81/src/pages/OnboardingWork/BaseOnboardingWork.tsx#L81-L84

we don't use ScreenWrapper in this component, we use KeyboardAvoidingView component but we don't pass correct props

What changes do you think we should make in order to solve the problem?

In these places

https://github.com/Expensify/App/blob/7b558ef7fb9908223d899b54ad3d0156bc8fcb81/src/pages/OnboardingWork/BaseOnboardingWork.tsx#L81-L84

https://github.com/Expensify/App/blob/7b558ef7fb9908223d899b54ad3d0156bc8fcb81/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx#L139-L142

I suggest to use ScreenWrapper on the outside and remove KeyboardAvoidingView

<ScreenWrapper
            includeSafeAreaPaddingBottom={false}
            shouldEnableMaxHeight
            shouldEnableKeyboardAvoidingView
            testID="BaseOnboardingWork">

What alternative solutions did you explore? (Optional)

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The continue button is hidden behind the keyboard

What is the root cause of that problem?

• In BaseOnboardingWork component, we use KeyboardAvoidingView component but do not have maxHeight style:

https://github.com/Expensify/App/blob/7b558ef7fb9908223d899b54ad3d0156bc8fcb81/src/pages/OnboardingWork/BaseOnboardingWork.tsx#L81-L84 so when the keyboard is opening, the CTA button is still at the bottom of the screen.

What changes do you think we should make in order to solve the problem?

• In general, we need to add the maxHeight style to the KeyboardAvoidingView like we did in ScreenWrapper component:

https://github.com/Expensify/App/blob/7b558ef7fb9908223d899b54ad3d0156bc8fcb81/src/components/ScreenWrapper.tsx#L258-L259

• In detail, we need to update: https://github.com/Expensify/App/blob/7b558ef7fb9908223d899b54ad3d0156bc8fcb81/src/pages/OnboardingWork/BaseOnboardingWork.tsx#L76-L84 to:

          <KeyboardAvoidingView
              style={[styles.h100, styles.dFlex, {maxHeight}, [styles.overflowAuto, styles.overscrollBehaviorContain]]}
              behavior="padding"
          >
              <HeaderWithBackButton
                  shouldShowBackButton
                  progressBarPercentage={OPEN_WORK_PAGE_PURPOSES.includes(onboardingPurposeSelected ?? '') ? 50 : 75}
                  onBackButtonPress={Navigation.goBack}
              />

  In the above changes, I swap the HeaderWithBackButton and KeyboardAvoidingView, then add style:

              style={[styles.h100, styles.dFlex, {maxHeight}, [styles.overflowAuto, styles.overscrollBehaviorContain]]}

  to the KeyboardAvoidingView.

• We can also apply the isAvoidingViewportScroll check like we did in ScreenWrapper: https://github.com/Expensify/App/blob/dd96852320612fd5188c95e659fce3814150af82/src/components/ScreenWrapper.tsx#L259

  What alternative solutions did you explore? (Optional)

• Should fix the similar screen in onboarding steps.

[rayane-djouah]

@lschurr Issue reporter commented to assign this to him as he have context. I am not sure I can assign him or not, Can you please confirm?

@lschurr - Commenting for C+ assignment, Thank you

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01ca1aa78c61096205

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[lschurr]

Assigned to you @m-natarajan - Could you review the proposal?

[rayane-djouah]

@lschurr - Sorry but you've assigned @m-natarajan from Applause instead of me

[melvin-bot[bot]]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[lschurr]

Oops! Sorry about that @rayane-djouah - good now.

[rayane-djouah]

@nkdengineer's proposal LGTM. It uses ScreenWrapper as other pages of the app.

:ribbon::eyes::ribbon: C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rayane-djouah]

Friendly Bump @robertjchen ^^

[robertjchen]

👍 to @nkdengineer 's proposal

[melvin-bot[bot]]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.12-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/45377

If no regressions arise, payment will be issued on 2024-08-02. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @rayane-djouah requires payment automatic offer (Contributor)
• @nkdengineer requires payment automatic offer (Contributor)
• @rayane-djouah requires payment automatic offer (Contributor)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@rayane-djouah] Determine if we should create a regression test for this bug.
• [ ] [@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

This is not overdue. Payment date is tomorrow.

[lschurr]

Payment summary:

• Contributor: $250 @nkdengineer (paid in Upwork)
• Reviewer: $250 @rayane-djouah (paid in Upwork)