[$250] Xero-LHN reports not displayed if login using xero connected a/c

izarutskaya commented 4 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.5 Reproducible in staging?: Y Reproducible in production?: Y Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

Go to https://staging.new.expensify.com/home in mweb
Tap profile - workspaces- worspace
Tap more features
Enable accounting
Connect xerox integration
Sync account using 3 dots
Login with same account on android

Expected Result:

User must be able to see LHN reports, if user login using xero integration connected account

Actual Result:

User sees woo-hoo all caught up message & not LHN reports, if user login using xero integration connected account

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/675a0533-8178-42ab-8279-4b7a806609cf

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01151d0e3495d1890c
Upwork Job ID: 1812859931445199078
Last Price Increase: 2024-07-22

Issue Owner

Current Issue Owner: @jayeshmangwani

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

izarutskaya commented 4 months ago

We think this issue might be related to the #vip-vsb

melvin-bot[bot] commented 4 months ago

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 4 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01151d0e3495d1890c

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

tienifr commented 4 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

User sees woo-hoo all caught up message & not LHN reports, if user login using xero integration connected account

What is the root cause of that problem?

When the user with Xero connection logs in again, Your organization requires two factor authentication error message will be returned by the back-end for OpenApp, ReconnectApp, so the data is unable to load.

We don't have handling for this case yet in the app.

What changes do you think we should make in order to solve the problem?

We need to add handling for case that the user is required to enable 2FA, we should:

If any API endpoint returns error that matches Your organization requires two factor authentication (we can check error message, error code or another field), or if account.needsTwoFactorAuthSetup is true, redirect the user to settings/security/two-factor-auth so they can enable the 2FA.
In the 2FA page, disable/hide the back button so the user cannot do anything unless set up the 2FA (check account.needsTwoFactorAuthSetup to know this)
In that 2FA page, show a noticeable error/warning that says they need to enable the 2FA because the organization requires so
If the user deep links to any page and 2FA is currently required for them, also do like step 1 and navigate them to the force-2FA page
After the 2FA is set up, log the user out so they can sign in again with 2FA enabled.

What alternative solutions did you explore? (Optional)

In step 5, alternatively we can trigger calling OpenApp/ReconnectApp again so the data is fetched properly, and still navigate the user to the Congratulations on 2FA set up page

jayeshmangwani commented 4 months ago

We need to add handling for case that the user is required to enable 2FA, we should:

@tienifr We have a similar issue https://github.com/Expensify/App/issues/43015 here, that will force workspace admins to enable 2FA before they can use the connection.

It looks like this issue will be solved after this PR https://github.com/Expensify/App/pull/44059 is merged. Correct me if I am wrong @c3024 @rushatgabhane.

rushatgabhane commented 4 months ago

@jayeshmangwani yep that's right

rushatgabhane commented 4 months ago

we should close this issue

jayeshmangwani commented 4 months ago

Thanks for the confirming Rushat, @muttmuure We can close this issue in favor of https://github.com/Expensify/App/issues/43015

melvin-bot[bot] commented 4 months ago

@jayeshmangwani, @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

jayeshmangwani commented 4 months ago

Not overdue. Issue can be closed, but Matt is OOO until Tuesday.

melvin-bot[bot] commented 3 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 3 months ago

@jayeshmangwani @muttmuure this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 3 months ago

@jayeshmangwani, @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

jayeshmangwani commented 3 months ago

@muttmuure We can close this issue. Please check this comment whenever you get a moment.

muttmuure commented 3 months ago

Ah yes, let's close. Thanks for the bump!

Expensify / App