Open lanitochka17 opened 1 month ago
Triggered auto assignment to @bfitzexpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-vsp
I guess this came from https://github.com/Expensify/App/pull/41962
I guess this came from https://github.com/Expensify/App/pull/41962
PR is not on Prod. yet this issue is also reproducable on prod. so not from https://github.com/Expensify/App/pull/41962
Chat scrolls back to linked message after receiving new message
Here:
and here:
We the useMemo
and useLayoutEffect
rely on route
, which comes from useRoute
. Every time the user receives a new message, the route object changes and triggers both useMemo
and useLayoutEffect
. Inside useMemo
, isFirstLinkedActionRender.current
is set to true, causing the report to scroll to the linked message.
The changes to the route object/navigation state occur due to:
The Navigation.setParams({ referrer: undefined })
call alters the navigation state and updates the route object.
To address this issue, we should add a check before executing Navigation.setParams({ referrer: undefined })
. For example:
if (isFromNotification) {
Navigation.setParams({ referrer: undefined });
}
Another approach could be to adjust the dependencies of useMemo
and useLayoutEffect
to use route.path
instead of route
.
i am interested in taking over this issue as c+, i have good context working on comment-linking related issues. : )
@bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.
Cool, assigning you @ishpaul777
Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.
@tsa321's Proposal looks good to me and test well.
🎀 👀 🎀 C+ reviewed
Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
fix for this was deployed to Prod yesterday.
cc: @bfitzexpensify . I think melvin automation broken here.
^^ cc @bfitzexpensify
@tsa321 can you please link your Upwork profile?
@bfitzexpensify my upwork profile: https://www.upwork.com/freelancers/~01bfc26d267bade652
Offer sent @tsa321.
I'm now out of office, so adding a BZ buddy to finalise the payout
@ishpaul777 can you complete the BZ checklist:
Triggered auto assignment to @lschurr (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@bfitzexpensify I have accepted the offer.
The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/41484/
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/41484/files#r1727608316
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: not required
Determine if we should create a regression test for this bug. Not requires
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N.A
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.5.0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): u.onyeukwu94@gmail.com Issue reported by: Applause - Internal Team
Issue found when executing PR https://github.com/Expensify/App/pull/44819
Action Performed:
Expected Result:
User receives new message smoothly
Actual Result:
Chat conversation scrolls up to highlighted message that was navigated to initially
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/54c40146-2a95-4c34-9e45-78c99b4ebb2d
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @