Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.29k stars 2.73k forks source link

[$250] Default group title not displayed for a group chat in LHN #45109

Closed m-natarajan closed 4 weeks ago

m-natarajan commented 1 month ago

If you havenโ€™t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: Needs reproduction Reproducible in production?: Needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @iwiznia Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1720438469855949

Action Performed:

Preferred language is set to Spanish

  1. Create a group chat with users
  2. As a group member observe the group title in LHN

    Expected Result:

    The group title is created with user names or email

Actual Result:

The group title not displayed as expected and clicking it displays the required format

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

image (10)

image (11)

report onyx entry: { "reportID": "65281652", "reportName": "Chat Report", "type": "chat", "chatType": "", "ownerAccountID": 0, "managerID": 0, "policyID": "FAKE", "participants": { "2536717": { "hidden": false } }, "isPinned": false, "lastReadTime": "2024-07-08 08:04:11.734", "lastReadSequenceNumber": 2166, "lastVisibleActionCreated": "2024-07-08 08:04:11.734", "lastVisibleActionLastModified": "2024-07-08 08:04:11.734", "lastMessageText": "Ah nice... when I was reading the doc I was not sure if I was confused between โ€ฆ", "lastActionType": "ADDCOMMENT", "lastActorAccountID": 2536717, "notificationPreference": "always", "stateNum": 0, "statusNum": 0, "oldPolicyName": "", "isOwnPolicyExpenseChat": false, "lastMessageHtml": "Ah nice... when I was reading the doc I was not sure if I was confused between submits and forwards or you were :smile:", "hasOutstandingChildRequest": false, "hasOutstandingChildTask": false, "writeCapability": "all", "description": "", "total": 0, "unheldTotal": 0, "currency": "USD", "isWaitingOnBankAccount": false, "nonReimbursableTotal": 0, "isCancelledIOU": false, "avatarUrl": "", "errorFields": {} } its report actions (key reportActions_65281652): { "2926707600442067114": { "person": [ { "type": "TEXT", "style": "strong", "text": "Tim Golen" } ], "actorAccountID": 2697693, "message": [ { "type": "COMMENT", "html": "What ping are you referring to?", "text": "What ping are you referring to?", "isEdited": false, "whisperedTo": [], "isDeletedParentAction": false, "deleted": "", "reactions": [] } ], "originalMessage": { "html": "What ping are you referring to?", "lastModified": "2024-04-16 18:56:00.355" }, "avatar": "https://d1wpcgnaa73g0y.cloudfront.net/af6290cc660450eb7a158fd28ac9ef31cf029a71_128.jpeg", "created": "2024-04-16 18:56:00.355", "timestamp": 1713293760, "reportActionTimestamp": 1713293760355, "automatic": false, "actionName": "ADDCOMMENT", "shouldShow": true, "reportActionID": "2926707600442067114", "previousReportActionID": "8563630657258046606", "lastModified": "2024-04-16 18:56:00.355", "childReportID": "4019934129907841", "childType": "chat", "childOldestFourAccountIDs": "2536717", "childReportNotificationPreference": "always", "childCommenterCount": 1, "childLastVisibleActionCreated": "2024-04-17 13:54:16.140", "childVisibleActionCount": 1, "whisperedToAccountIDs": [] } } the personal details of that account (2697693): { "accountID": 2697693, "avatar": "https://d1wpcgnaa73g0y.cloudfront.net/af6290cc660450eb7a158fd28ac9ef31cf029a71_128.jpeg", "firstName": "Tim", "lastName": "Golen", "status": { "clearAfter": "2024-07-15 03:10:00", "emojiCode": ":x:", "text": "OOO Until July 15" }, "displayName": "Tim Golen", "login": "tgolen@expensify.com", "pronouns": "", "timezone": { "automatic": true, "selected": "America/Denver" }, "phoneNumber": "", "validated": true }

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019dcfec9f12017fdf
  • Upwork Job ID: 1816831121144562290
  • Last Price Increase: 2024-07-26
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

MelvinBot commented 1 month ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

johncschuster commented 1 month ago

@iwiznia I tried reproducing this using two of my test accounts, and when I checked the title of the group that was generated in the LHN, I saw a group chat called John, John, John. It sounds like I should expect exactly that, right?

2024-07-12_16-08-14 2024-07-12_16-07-53 2024-07-12_16-08-41

johncschuster commented 1 month ago

@iwiznia are you still seeing this behavior? If so, can you clarify the repro steps? I couldn't reproduce it.

iwiznia commented 1 month ago

tried reproducing this using two of my test accounts, and when I checked the title of the group that was generated in the LHN, I saw a group chat called John, John, John. It sounds like I should expect exactly that, right?

lol yes that seems correct but you picked the most confusing case to test it with ๐Ÿ˜‚

@iwiznia are you still seeing this behavior? If so, can you clarify the repro steps? I couldn't reproduce it.

Yes, I am still seeing this in some reports and no I don't know how to reproduce it

johncschuster commented 1 month ago

lol yes that seems correct but you picked the most confusing case to test it with ๐Ÿ˜‚

๐Ÿ˜‚ ๐Ÿ˜‚ ๐Ÿ˜‚ I've never been one to make it easy on myself ๐Ÿ˜…

Well, I'll ask Applause to try reproducing it.

melvin-bot[bot] commented 1 month ago

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

johncschuster commented 1 month ago

Asked in Slack

melvin-bot[bot] commented 1 month ago

@johncschuster this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

johncschuster commented 1 month ago

Bumped in Slack

johncschuster commented 1 month ago

Applause can't reproduce it either.

Following these steps: What is the process for BZ managing issues that can't be reproduced? needs reproduction

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~019dcfec9f12017fdf

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

johncschuster commented 1 month ago

@ishpaul777 both Applause and I have been unable to reproduce this behavior. Can you try reproducing it?

ishpaul777 commented 1 month ago

Not reproducable, however looking at onyx data it appears report has only one participant

{
    "participants": {
        "2536717": {
            "hidden": false
        }
    }
}

Thats why this shows this title, from this condition

https://github.com/Expensify/App/blob/69f2c0530272ef337c76fe6e4435313b073c526e/src/libs/ReportUtils.ts#L1999-L2009

melvin-bot[bot] commented 1 month ago

@johncschuster, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

ishpaul777 commented 1 month ago

not overdue, looking at onyx data this appears to be expected behaviour to me...

melvin-bot[bot] commented 1 month ago

@johncschuster, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

johncschuster commented 1 month ago

Not overdue^^

mvtglobally commented 1 month ago

Issue not reproducible during KI retests. (First week)

ishpaul777 commented 1 month ago

not reproducable and not overdue

melvin-bot[bot] commented 1 month ago

@johncschuster @ishpaul777 this issue is now 4 weeks old, please consider:

Thanks!

johncschuster commented 4 weeks ago

Given this cannot be reproduced, I'm going to close the issue.