[HOLD for payment 2024-07-24] [$125] [Payment Card / Subscription] Update the payment card icon in the Subscription tab

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.29k stars 2.72k forks source link

[HOLD for payment 2024-07-24] [$125] [Payment Card / Subscription] Update the payment card icon in the Subscription tab #45123

Closed MitchExpensify closed 1 month ago

MitchExpensify commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.5-10 Reproducible in staging?: Staging Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: NA Email or phone of affected tester (no customers): Logs: NA Expensify/Expensify Issue URL: NA Issue reported by: mitch@expebsify.com Slack conversation: Internal: https://expensify.slack.com/archives/C036QM0SLJK/p1720560965872139?thread_ts=1720544914.651789&cid=C036QM0SLJK

Action Performed:

Open new.expensify.com/settings/subscription

Expected Result:

New Feature, the card icon in the Payment section look like this:

Actual Result:

The card icon is darker than expected:

Workaround:

Ignore it

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Added above

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01131af4be64782018
Upwork Job ID: 1810980051927666414
Last Price Increase: 2024-07-10
Automatic offers:

Krishna2323 | Contributor | 103066408

Issue Owner

Current Issue Owner: @Christinadobrzyn

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Krishna2323 commented 1 month ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the payment card icon in the Subscription tab

What is the root cause of that problem?

The background color is not correct. https://github.com/Expensify/App/blob/54999880458a4c18204a56e37e1d4952a68b3b5a/src/styles/index.ts#L2876

What changes do you think we should make in order to solve the problem?

Update it to theme.buttonDefaultBG. Also update the fill={theme.text} to fill={theme.icon} here.

What alternative solutions did you explore? (Optional)

Result

https://github.com/Expensify/App/assets/85894871/c33c723f-e8b6-42d5-bfc4-c690d909e78a

trjExpensify commented 1 month ago

Going to export this at $125 as it's a simple icon change.

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~01131af4be64782018

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

melvin-bot[bot] commented 1 month ago

Upwork job price has been updated to $125

parasharrajat commented 1 month ago

I didn't understand the issue at all from the description. What needs to be changed @trjExpensify?

trjExpensify commented 1 month ago

This icon is too dark:

parasharrajat commented 1 month ago

@Krishna2323's proposal looks good to me.

:ribbon: :eyes: :ribbon: C+ reviewed

melvin-bot[bot] commented 1 month ago

Current assignee @blimpich is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

melvin-bot[bot] commented 1 month ago

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

Krishna2323 commented 1 month ago

@parasharrajat, PR ready for review.

Christinadobrzyn commented 1 month ago

PR in staging - getting close! https://github.com/Expensify/App/pull/45219

melvin-bot[bot] commented 1 month ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.7-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/45219

If no regressions arise, payment will be issued on 2024-07-24. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@parasharrajat requires payment through NewDot Manual Requests
@Krishna2323 requires payment automatic offer (Contributor)

melvin-bot[bot] commented 1 month ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x] [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[x] [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[x] [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[x] [@parasharrajat] Determine if we should create a regression test for this bug.
[x] [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[x] [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/415142

Christinadobrzyn commented 1 month ago

Preparing for payment

Payouts due:

[X] Contributor: $125 @Krishna2323 (Paid in Upwork - https://www.upwork.com/nx/wm/workroom/37781500/overview)
Contributor+: $125 @parasharrajat (paid through New Dot)

@parasharrajat do we need a regression test for this?

parasharrajat commented 1 month ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x] [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: A minor change
[x] [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Not needed
[x] [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed
[x] [@parasharrajat] Determine if we should create a regression test for this bug. No
[x] [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Go to /settings/subscription
Verify the card icon and background in light & dark mode

Do you agree 👍 or 👎 ?

Christinadobrzyn commented 1 month ago

Payment day -

Regression test - https://github.com/Expensify/Expensify/issues/415142
Payment summary - https://github.com/Expensify/App/issues/45123#issuecomment-2246066127

Closing this out since @parasharrajat will be paid through NewDot.

parasharrajat commented 1 month ago

Payment requested as per https://github.com/Expensify/App/issues/45123#issuecomment-2246066127

JmillsExpensify commented 1 month ago

$125 approved for @parasharrajat