search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.79k forks source link

Mark down - The sent message containing two > does not display double quote mark down #45154

Open lanitochka17 opened 2 months ago

lanitochka17 commented 2 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.6-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to chat
  3. Type >> hello
  4. Note that the live mark down displays the nested quote
  5. Send the message

Expected Result:

The sent message containing two > will display double quote mark down

Actual Result:

The sent message containing two > does not display double quote mark down

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/dccd694c-d8c6-4022-a99f-1721185b16bf

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @JmillsExpensify
melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 2 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
lanitochka17 commented 2 months ago

@pecanoro FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 2 months ago

We think that this bug might be related to #vip-vsp

devguest07 commented 2 months ago

Caused by https://github.com/Expensify/App/pull/44262

pecanoro commented 2 months ago

Confirmed and posted in the PR, we probably need to assign the people to fix it!

pecanoro commented 2 months ago

Oh, but maybe we don't need to hold on this as it only happens when you do >> which it's an edge case

mountiny commented 2 months ago

Yeah lets not hold on this, we have to get to higher version of the markdown library and this does not seem that big issue

Please feel free to reassign to me, happy to handle this with swm or community upstream

mountiny commented 2 months ago

cc @Skalakid @BrtqKr @BartoszGrajdek @tomekzaw

BartoszGrajdek commented 2 months ago

I think @BrtqKr will be the best person to help you here since he was the one working on block quotes 🙌🏻

BrtqKr commented 2 months ago

Blockquote requires a space following it. If there are two blockquotes, they still need to be separated with a space. This was meant to allow empty lines to be treated as a part of the blockquote and prevent some of the issues with treating '>' as a blockquote unintentionally. I think this should go the other way - the input shouldn't show that this would result in a blockquote.

pecanoro commented 2 months ago

@BrtqKr Let me know if I am following correctly, the problem here is that the composer should not show the preview of the markdown, right?

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 months ago

@JmillsExpensify @pecanoro @BrtqKr this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

pecanoro commented 2 months ago

@BrtqKr Any updates on when we will have this one fixed?

BrtqKr commented 2 months ago

@pecanoro @lanitochka17 @JmillsExpensify There have been a lot of issues related to the behavior of blockquotes, describing different, sometimes conflicting results as desired. We've been discussing it internally and we think we should take a different approach in this case. Can we please:

  1. Pass this document further inside the Expensify team.
  2. Make the decisions regarding cases described in the document.
  3. Create a single ticket to adjust those behaviors on both sides - the input and the parser. And redirect all blockquotes-related reports to that place

We think that we're lacking a single source of truth with an appropriate description for the parser and the general approach to fixing those things seems a bit chaotic and blindly adjusting regexes without a broad context might not be the best workflow.

melvin-bot[bot] commented 1 month ago

This issue has not been updated in over 15 days. @JmillsExpensify, @pecanoro, @BrtqKr eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

pecanoro commented 1 month ago

@JmillsExpensify Since it's product design related, could you handle this? https://github.com/Expensify/App/issues/45154#issuecomment-2252238031

ChavdaSachin commented 1 month ago

Checkout alternate method I suggested in this proposal It solves this issue as well and we will gain similar behavior for composer and report message. Issue -https://github.com/Expensify/App/issues/47951#issue-2484028828