Closed lanitochka17 closed 1 week ago
Triggered auto assignment to @muttmuure (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Triggered auto assignment to @yuwenmemon (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
:wave: Friendly reminder that deploy blockers are time-sensitive β± issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Able to reproduce.
Installing a fresh simulator to give this a test
Seems like this is coming from reanimated, and the ImageCropView component - but nothing was recently changed about them on the staging version π€
@roryabraham Could this somehow have affected the reanimated patch that we apply on staging?
We renamed the reanimated patches here and I'm not sure why π€ - but it looks awfully sus
I don't think this is related to backend, removing the DeployBlocker
tag
@roryabraham Could this somehow have affected the reanimated patch that we apply on staging?
Tagging the other PR reviewers who are also familiar with the changes: @AndrewGable @fabioh8010
Damn, I can't reproduce on dev with the iOS simulator π€
Ah, we renamed them to reflect the current version of reanimated we're using in the app.
No, I don't think that PR would have affected the Reanimated patch. All that PR does is fail patch-package if it has an errors or warnings.
For the Reanimated patches, they produced warnings because we had updated the version of Reanimated we were using without updating the patches accordingly. This was a mistake easily missed by reviewers, but my PR would have prevented it. In order to get β on the PR, I had to rename the Reanimated patches to suppress the warning(s).
Why do I say this likely did not cause the crash? Because patch-package was already applying the reanimated patches despite the version mis-match. So app should have been unaffected
The warning that I fixed looks like this:
Warning: patch-package detected a patch file version mismatch
Don't worry! This is probably fine. The patch was still applied
successfully. Here's the deets:
Patch file created for
react-native-reanimated@3.7.2
applied to
react-native-reanimated@3.8.1
At path
node_modules/react-native-reanimated
This warning is just to give you a heads-up. There is a small chance of
breakage even though the patch was applied successfully. Make sure the package
still behaves like you expect (you wrote tests, right?) and then run
patch-package react-native-reanimated
to update the version in the patch file name and make this warning go away.
We're trying a revert of Rory's PR here: https://github.com/Expensify/App/pull/45312
Job added to Upwork: https://www.upwork.com/jobs/~012a2b40164b680402
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External
)
Let's see if anyone from the community has an idea how to fix. I think we'd want to build on https://github.com/Expensify/App/pull/45314 in some way maybe
App crashes when uploading an avatar.
Just as the error message states, tried to synchronously call non-worklet functions on the UI thread.
In addition to @yuwenmemon's PR https://github.com/Expensify/App/pull/45314, we need to make the function below a worklet too. https://github.com/Expensify/App/blob/fef8ef8c30e69b1807c9ec958e744dbc37816597/src/components/AvatarCropModal/ImageCropView.tsx#L59-L67
N/A
App crashes when uploading an avatar.
The issue happens inside the Slider component.
in useAnimatedStyle
function we didn't add the dependencies array
We need to add the dependencies array and add the SliderValue
inside it.
const rSliderStyle = useAnimatedStyle(() => ({
transform: [{translateX: sliderValue.value}],
}), [sliderValue]);
https://github.com/user-attachments/assets/49e653ca-9fe6-4518-80f6-a520cf0f3d89
N/A
I think my solution also fixes this issue #45164 maybe partially. it makes the slider moves after click to show that the image is zoomed.
Exellent find @Ahmed-Abdella. This is the much simpler solution and I'm going to go ahead and create the PR myself now due to the high priority. Assigning you for the bounty.
@QichenZhu I would be interested to hear more about your proposals perhaps it is a secondary fix that should be made on top of the simpler changes?
π£ @Ahmed-Abdella π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ»
Keep in mind: Code of Conduct | Contributing π
Again, no need for the PR here.
I think my solution also fixes this issue #45164 maybe partially. it makes the slider moves after click to show that the image is zoomed.
If I remember correctly, that is the same behaviour that we saw last week.
Commenting for the assignment
@QichenZhu I would be interested to hear more about your proposals perhaps it is a secondary fix that should be made on top of the simpler changes?
@Julesssss Thanks for your interest. My proposal is on top of @yuwenmemon's PR https://github.com/Expensify/App/pull/45314. Regarding the simpler solution by adding a dependencies array, it was also my initial thought. Unfortunately, it didn't fix the crash on iOS native.
Thanks @Julesssss for your words and offer accepted.
Looks like there are some changes happened in the behavior of the useAnimatedStyle
and the Reanimated
package in 3.8.0. Maybe this PR in react-native-reanimated and it's related issue help us to understand. I also found many other issues around the usAnimatedStyle
dependencies Array.
I will keep working on this trying to solve the other issue #45164
@Ahmed-Abdella for iOS it is still throwing an error [Reanimated] Tried to synchronously call a non-worklet function on the UI thread.
Will check Now
@Julesssss @Pujan92 My proposal works on iOS.
https://github.com/user-attachments/assets/bfeb64e9-e127-45d0-8ba1-052b68ae97a0
@QichenZhu -- yeah, I missed that the accepted proposal didn't work on iOS.
Do you think your solution would work alongside the accepted proposal?
@Julesssss Tested and it doesn't work with the accepted proposal, but works with https://github.com/Expensify/App/pull/45314.
I will keep working on this trying to solve the other issue https://github.com/Expensify/App/issues/45164
Okay thanks, in the meantime I'll need to switch proposals as this issue is a major blocker for us internally. We can sort out bounties later.
@Julesssss Tested and it doesn't work with the accepted proposal, but works with #45314.
@QichenZhu could you please go ahead with your proposal? I have just merged @yuwenmemon's PR, so pleasepull main before you branch from it.
π£ @QichenZhu π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
Thanks, @Julesssss! Starting now.
Okay thanks, in the meantime I'll need to switch proposals as this issue is a major blocker for us internally. We can sort out bounties later.
@Julesssss Sure thing. I just couldn't test it on iOS because there was a bug causing an iOS build failure.
Hey @Pujan92, @QichenZhu's PR is ready for testing now/ Let us know if you aren't available. thanks
Yes @Julesssss , looking into it and testing
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.7-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-24. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
@yuwenmemon, @Pujan92, @applausebot, @muttmuure, @QichenZhu, @Ahmed-Abdella Whoops! This issue is 2 days overdue. Let's get this updated quick!
@Pujan92 - $250 C+ @QichenZhu - $250 C @Ahmed-Abdella - $250 C
@Pujan92 can you clarify if we need a regression test?
$250 approved for @Pujan92
@yuwenmemon, @Pujan92, @applausebot, @muttmuure, @QichenZhu, @Ahmed-Abdella Whoops! This issue is 2 days overdue. Let's get this updated quick!
@yuwenmemon, @Pujan92, @applausebot, @muttmuure, @QichenZhu, @Ahmed-Abdella Still overdue 6 days?! Let's take care of this!
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.6.0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+uo0710@applause.expensifail.com Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
New profile picture is uploaded
Actual Result:
The app crashes on edit profile picture screen
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/515d1072-afba-4c01-a9f5-aac9e70ad95b
https://github.com/Expensify/App/assets/78819774/24424bb1-0bfe-4d20-9b0c-0e12a67925c1
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @muttmuure