Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.42k stars 2.8k forks source link

Update Invoices setting screen #45175

Open madmax330 opened 2 months ago

madmax330 commented 2 months ago

Part of the Invoicing payments project

Main issue: https://github.com/Expensify/Expensify/issues/382977 Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.sidhyk9taftq Project: https://github.com/orgs/Expensify/projects/114/views/3

Feature Description

Manual Test Steps

Automated Tests

danielrvidal commented 1 month ago

I think this is just waiting for payment, right @madmax330 ?

madmax330 commented 1 month ago

Yeah we need to pay the c+ for their review

cretadn22 commented 3 weeks ago

@madmax330 @danielrvidal

I am working on https://github.com/Expensify/App/issues/48345 and need to remove ROUTES.WORKSPACE_INVOICES

But I see a note:

https://github.com/Expensify/App/blob/812fc316a007b711d62a986582d19440c2c1dad8/src/pages/home/report/ReportActionItemMessage.tsx#L136

Should we remove this comment?

madmax330 commented 3 weeks ago

cc @VickyStash I don't think we want to remove it right?

VickyStash commented 3 weeks ago

Yeah, ROUTES.WORKSPACE_INVOICES route will be reused in the future.

melvin-bot[bot] commented 1 day ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.