Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.48k stars 2.84k forks source link

Invoicing details section #45176

Open madmax330 opened 3 months ago

madmax330 commented 3 months ago

Part of the Invoicing payments project

Main issue: https://github.com/Expensify/Expensify/issues/382977 Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.xlgprr5mxnso Project: https://github.com/orgs/Expensify/projects/114/views/3

Feature Description

Manual Test Steps

Automated Tests

VickyStash commented 2 months ago

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

VickyStash commented 2 months ago

Updates:

Implemented WorkspaceInvoicingDetailsSection component
Implement pages to update company name and company website

TODOs:

Implement forms validation and submitting.

Updates can be tracked in Draft PR

VickyStash commented 2 months ago

Updates:

Implemented forms validation, added needed for future TODO's
Added test steps and part of recordings to the Draft PR. Overall the Draft if almost ready for the review. But I think it makes sense to open it only when https://github.com/Expensify/App/pull/46009 is merged, cause their functionality is overlapping.

VickyStash commented 2 months ago

ON HOLD till https://github.com/Expensify/App/pull/46009 is merged

VickyStash commented 2 months ago

The PR has been opened for the review

melvin-bot[bot] commented 1 month ago

This issue has not been updated in over 15 days. @madmax330, @VickyStash eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

rezkiy37 commented 1 week ago

@madmax330 @VickyStash should we close this issue?

VickyStash commented 1 week ago

@rezkiy37 We need to make the Invoicing details section:

be displayed on the Invoice settings screen (mentioned here as well)
integrate the BE calls (here and here)

After that we can close the issue.

rezkiy37 commented 1 week ago

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

rezkiy37 commented 1 week ago

Actively working on the issue.