search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.87k forks source link

Invoice bank accounts section #45177

Closed madmax330 closed 1 week ago

madmax330 commented 3 months ago

Part of the Invoicing payments project

Main issue: https://github.com/Expensify/Expensify/issues/382977 Doc section: https://docs.google.com/document/d/1CF5gw-SJx7ckZCgTJNj1IqBnsRuSxD2Bfd_uB5rRGxk/edit#heading=h.27ed1nyheq5 Project: https://github.com/orgs/Expensify/projects/114/views/3

Feature Description

Manual Test Steps

Automated Tests

rezkiy37 commented 2 months ago

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

danielrvidal commented 2 months ago

@rezkiy37 is this done now or are we waiting for anything?

rezkiy37 commented 2 months ago

Discussion in Slack.

rezkiy37 commented 2 months ago

Hey! I will be OOO from 04.09 (afternoon) till 09.09. I will continue to work on this one once I am back.

rezkiy37 commented 1 month ago

Hello! I am OOO from 19.09 - 23.09. I will continue to work on this one when I am back. Meanwhile, @waterim will work on this issue.

rezkiy37 commented 1 month ago

I've integrated the SetInvoicingTransferBankAccount command. I am implementing other front-end parts.

Pujan92 commented 1 month ago

I requested for the doc access

melvin-bot[bot] commented 1 week ago

This issue has not been updated in over 15 days. @madmax330, @rezkiy37 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

davidcardoza commented 1 week ago

What's the latest update on this?

Pujan92 commented 1 week ago

Changes were in production 3 weeks ago, so now this is due for the payment.

rezkiy37 commented 1 week ago

The PR (https://github.com/Expensify/App/pull/47218) was merged. So we can finish with the issue.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

madmax330 commented 1 week ago

@sonialiap for this one can you just do the payment for 2 reviews for @Pujan92 ?

sonialiap commented 1 week ago

Payment summary:

garrettmknight commented 5 days ago

$500 approved for @Pujan92