search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.29k stars 2.72k forks source link

Accounting - Non-reimbursable expense becomes empty after going offline and online #45191

Closed lanitochka17 closed 1 month ago

lanitochka17 commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.6-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Issue found when executing PR https://github.com/Expensify/App/pull/44921

Action Performed:

Pre-requisite

Expected Result:

The value in Non-reimbursable expense persists

Actual Result:

The value in Non-reimbursable expense becomes empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/d99a90e7-f5d7-4b78-99f0-e033e0989c37

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 1 month ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
lanitochka17 commented 1 month ago

@Gonals FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Gonals commented 1 month ago

Hmm. This looks like a backend issue, at first glance. Can it be reproduced consistently?

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Gonals commented 1 month ago

Ok, that field is not working at all. It is not a blocker, as this is new functionality and doesn't break any existing stuff, but we need to fix it. I'll look more into it today/tomorrow

Gonals commented 1 month ago

Yeeep. This is a typo in the backend. Fix incoming

Christinadobrzyn commented 1 month ago

I assume we can move this from hourly to daily now that a PR is in the works. @Gonals does that sound okay?

Gonals commented 1 month ago

Yep!

Christinadobrzyn commented 1 month ago

Update for Melvin- working on PR https://github.com/Expensify/Web-Expensify/pull/42707

Christinadobrzyn commented 1 month ago

I think I'm going to move this to weekly since we're working on PR - https://github.com/Expensify/Web-Expensify/pull/42707

Christinadobrzyn commented 1 month ago

PR is in production - https://github.com/Expensify/Web-Expensify/pull/42707 as of the 16th. Can we close this out @Gonals and @lakchote?

Christinadobrzyn commented 1 month ago

I'm going to close this out. We can reopen if needed.