[HOLD for payment 2024-08-01] [$50] Search icon has no safe area around and its hard to tap

m-natarajan commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.6-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @mountiny Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1720613707699899

Action Performed:

Launch the app
Tap the Search icon for the chat selector
Expected Result:

The search icon tappable should be around the button anywhere

Actual Result:

Search icon seems so have super small safe area around, you really need to tap exactly on the search icon to open

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

image (12)

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @anmurali

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011f8d2de869135cc4
Upwork Job ID: 1811159428371033529
Last Price Increase: 2024-07-10
Automatic offers:

rayane-djouah | Contributor | 103071138

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Krishna2323 commented 1 month ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search icon seems so have super small safe area around, you really need to tap exactly on the search icon to open

What is the root cause of that problem?

No fixed height and width is assigned to PressableWithoutFeedback container. https://github.com/Expensify/App/blob/98932a26522e75239b5c7b73fda519f84936f75c/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/TopBar.tsx#L62-L71

What changes do you think we should make in order to solve the problem?

Add styles.touchableButtonImage to styles object and remove styles.mr2. We might also need to align the icon a bit by adding some left/right margin.

We can also add role={CONST.ROLE.BUTTON} if needed.

What alternative solutions did you explore? (Optional)

Result

https://github.com/Expensify/App/assets/85894871/7c5c0787-6a57-4af6-b030-64363dd1d5c4

Krishna2323 commented 1 month ago

Proposal updated

neonbhai commented 1 month ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search icon seems so have super small safe area around, you really need to tap exactly on the search icon to open

What is the root cause of that problem?

We don't have any padding around the Search icon, making the hitbox small.

What changes do you think we should make in order to solve the problem?

We will add styles.p1 to the button styles here, so the hitbox is bigger.

https://github.com/Expensify/App/blob/98932a26522e75239b5c7b73fda519f84936f75c/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/TopBar.tsx#L62-L66

style={[styles.flexRow, styles.mr2, styles.p1]}

Result

Before

Hitbox in red. Area is small and easy to miss Screenshot 2024-07-11 at 12 38 27 AM

After

Hitbox in red. Added breathing space Screenshot 2024-07-11 at 12 36 59 AM

Without hitbox highlight:

mountiny commented 1 month ago

I will make this external for $50 as its super easy

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~011f8d2de869135cc4

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

melvin-bot[bot] commented 1 month ago

Upwork job price has been updated to $50

mountiny commented 1 month ago

@Ollyws all yours now

Krishna2323 commented 1 month ago

@mountiny, I agree it's an easy one, but it still required time to determine the appropriate styling. I propose using the same styling as the back button, which would maintain consistency and aligns with how we style other icons. Additionally, we invest fair amount of time recording videos for each platform. Therefore, I'd like to request an increase to $125. That's my perspective, and I'm open to hearing your thoughts.

rayane-djouah commented 1 month ago

Taking over as C+ (https://expensify.slack.com/archives/C02NK2DQWUX/p1720649616158539)

rayane-djouah commented 1 month ago

@Krishna2323's proposal looks good to me. I think using the same styling as the back button sounds good (we use styles.touchableButtonImage in a lot of similar icons).

:ribbon::eyes::ribbon: C+ reviewed

melvin-bot[bot] commented 1 month ago

Current assignee @mountiny is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

melvin-bot[bot] commented 1 month ago

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

mountiny commented 1 month ago

@Krishna2323 lets stick with $50 for now and see if there will be any reason to bump to $125.

mountiny commented 1 month ago

44x44 is the apple standard minimum for the button so lets try to implement that please @Krishna2323 thanks!

Krishna2323 commented 1 month ago

44x44 only for search icon, right? We generally use 40x40 for icons (e.g. close, download, question mark, pin).

rayane-djouah commented 1 month ago

I think we can use shouldUseAutoHitSlop PressableWithFeedback's property for this

Krishna2323 commented 1 month ago

@mountiny, whats's your thoughts on comments above?

mountiny commented 1 month ago

I think we can use shouldUseAutoHitSlop PressableWithFeedback's property for this

I think this sounds like a good idea

mountiny commented 1 month ago

@Krishna2323 what is your eta for the PR? Thanks!

Krishna2323 commented 1 month ago

@mountiny, build is failing for ios/android native for me. I'm trying to fix that, will raise pr as soon as it gets resolved.

Krishna2323 commented 1 month ago

@mountiny @rayane-djouah, PR is ready. I have used the touchableButtonImage for this, shouldUseAutoHitSlop will not work on web.

melvin-bot[bot] commented 1 month ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.11-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/45380

If no regressions arise, payment will be issued on 2024-08-01. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@rayane-djouah requires payment automatic offer (Contributor)
@Krishna2323 requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 1 month ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@rayane-djouah] Determine if we should create a regression test for this bug.
[ ] [@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[x] [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

rayane-djouah commented 3 weeks ago

[x] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/37421
[x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/37421/files#r1702108483
[x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[x] Determine if we should create a regression test for this bug. Yes
[x] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Launch the app
Tap around the Search icon for the chat selector
Verify Search icon has tappable area round it

Do we agree 👍 or 👎

rayane-djouah commented 3 weeks ago

cc @anmurali

melvin-bot[bot] commented 3 weeks ago

@anmurali, @mountiny, @rayane-djouah, @Krishna2323 Eep! 4 days overdue now. Issues have feelings too...

anmurali commented 3 weeks ago

@rayane-djouah is paid @Krishna2323 can you pls link me your Upwork profile?

Krishna2323 commented 3 weeks ago

@anmurali, Upwork profile.

melvin-bot[bot] commented 2 weeks ago

@anmurali, @mountiny, @rayane-djouah, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 2 weeks ago

@anmurali, @mountiny, @rayane-djouah, @Krishna2323 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

anmurali commented 2 weeks ago

@Krishna2323 offer is here

Krishna2323 commented 2 weeks ago

Accepted, thanks.

melvin-bot[bot] commented 1 week ago

@anmurali, @mountiny, @rayane-djouah, @Krishna2323 Eep! 4 days overdue now. Issues have feelings too...

rayane-djouah commented 1 week ago

@anmurali - What's the latest here?

melvin-bot[bot] commented 1 week ago

@anmurali, @mountiny, @rayane-djouah, @Krishna2323 Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] commented 6 days ago

@anmurali, @mountiny, @rayane-djouah, @Krishna2323 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

anmurali commented 3 days ago

This was paid a while back. Closing!

Expensify / App