Closed m-natarajan closed 3 days ago
Triggered auto assignment to @anmurali (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Search icon seems so have super small safe area around, you really need to tap exactly on the search icon to open
No fixed height and width is assigned to PressableWithoutFeedback
container.
https://github.com/Expensify/App/blob/98932a26522e75239b5c7b73fda519f84936f75c/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/TopBar.tsx#L62-L71
Add styles.touchableButtonImage
to styles object and remove styles.mr2
. We might also need to align the icon a bit by adding some left/right
margin.
We can also add role={CONST.ROLE.BUTTON}
if needed.
https://github.com/Expensify/App/assets/85894871/7c5c0787-6a57-4af6-b030-64363dd1d5c4
Search icon seems so have super small safe area around, you really need to tap exactly on the search icon to open
We don't have any padding around the Search icon, making the hitbox small.
We will add styles.p1
to the button styles here, so the hitbox is bigger.
style={[styles.flexRow, styles.mr2, styles.p1]}
I will make this external for $50 as its super easy
Job added to Upwork: https://www.upwork.com/jobs/~011f8d2de869135cc4
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External
)
Upwork job price has been updated to $50
@Ollyws all yours now
@mountiny, I agree it's an easy one, but it still required time to determine the appropriate styling. I propose using the same styling as the back button, which would maintain consistency and aligns with how we style other icons. Additionally, we invest fair amount of time recording videos for each platform. Therefore, I'd like to request an increase to $125. That's my perspective, and I'm open to hearing your thoughts.
Taking over as C+ (https://expensify.slack.com/archives/C02NK2DQWUX/p1720649616158539)
@Krishna2323's proposal looks good to me. I think using the same styling as the back button sounds good (we use styles.touchableButtonImage
in a lot of similar icons).
:ribbon::eyes::ribbon: C+ reviewed
Current assignee @mountiny is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
@Krishna2323 lets stick with $50 for now and see if there will be any reason to bump to $125.
44x44 is the apple standard minimum for the button so lets try to implement that please @Krishna2323 thanks!
44x44
only for search icon, right? We generally use 40x40
for icons (e.g. close, download, question mark, pin).
I think we can use shouldUseAutoHitSlop
PressableWithFeedback
's property for this
@mountiny, whats's your thoughts on comments above?
I think we can use shouldUseAutoHitSlop PressableWithFeedback's property for this
I think this sounds like a good idea
@Krishna2323 what is your eta for the PR? Thanks!
@mountiny, build is failing for ios/android native for me. I'm trying to fix that, will raise pr as soon as it gets resolved.
@mountiny @rayane-djouah, PR is ready. I have used the touchableButtonImage
for this, shouldUseAutoHitSlop
will not work on web.
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.11-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-01. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression Test Proposal
Do we agree 👍 or 👎
cc @anmurali
@anmurali, @mountiny, @rayane-djouah, @Krishna2323 Eep! 4 days overdue now. Issues have feelings too...
@rayane-djouah is paid @Krishna2323 can you pls link me your Upwork profile?
@anmurali, Upwork profile.
@anmurali, @mountiny, @rayane-djouah, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!
@anmurali, @mountiny, @rayane-djouah, @Krishna2323 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
Accepted, thanks.
@anmurali, @mountiny, @rayane-djouah, @Krishna2323 Eep! 4 days overdue now. Issues have feelings too...
@anmurali - What's the latest here?
@anmurali, @mountiny, @rayane-djouah, @Krishna2323 Still overdue 6 days?! Let's take care of this!
@anmurali, @mountiny, @rayane-djouah, @Krishna2323 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
This was paid a while back. Closing!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.6-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @mountiny Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1720613707699899
Action Performed:
Expected Result:
The search icon tappable should be around the button anywhere
Actual Result:
Search icon seems so have super small safe area around, you really need to tap exactly on the search icon to open
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @anmuraliUpwork Automation - Do Not Edit