search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.87k forks source link

[$250] QBO - The toggles are enabled and disabled twice in Advanced settings #45201

Closed lanitochka17 closed 2 months ago

lanitochka17 commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.6-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4706857 Issue reported by: Applause - Internal Team

Action Performed:

Precondition QBO connection is established in the workspace

  1. Navigate to workspace settings > Accounting
  2. Click on Advanced
  3. Enable and disable the toggles of the items a few times
  4. Observe how the toggles are behaving after enabling and disabling a few times

Expected Result:

Enabling and disabling occurs only once

Actual Result:

Toggles are enabled and disabled twice when the action is performed only once

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/1fc98280-3c82-4971-a2b4-748c23dd6281

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01123cce366aa8f37d
  • Upwork Job ID: 1811816997002609504
  • Last Price Increase: 2024-08-08
  • Automatic offers:
    • ahmedGaber93 | Reviewer | 103330245
Issue OwnerCurrent Issue Owner: @aldo-expensify
zanyrenney commented 2 months ago

Nice, thanks @aldo-expensify

zanyrenney commented 2 months ago

how are you getting on with this one @aldo-expensify ?

aldo-expensify commented 2 months ago

I haven't got to it yet, I'll give it some time today

aldo-expensify commented 2 months ago

PR up: https://github.com/Expensify/Web-Expensify/pull/43173

zanyrenney commented 2 months ago

Nice, good work on the PR. @aldo-expensify - looks like the comments from Franc and Rocio have been resolved. Can you merge this today?

ahmedGaber93 commented 2 months ago

I don't think this issue is need a C+ yet. Unassigning me

aldo-expensify commented 2 months ago

The PR https://github.com/Expensify/Web-Expensify/pull/43173 is in staging

rezkiy37 commented 2 months ago

It works properly now in staging.

https://github.com/user-attachments/assets/e1e7a2dd-953c-4162-9998-70e9c86b9b0c