Closed izarutskaya closed 4 weeks ago
Triggered auto assignment to @puneetlath (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
In ContactMethodsPage
, the loginList
data:
https://github.com/Expensify/App/blob/58e257532290aa0228f1c668ed461a15f1b2b136/src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx#L135-L137
contains the login data which has partnerName: "chat-expensify-com"
but we do not need it in this page.
We need to create a login list selector, that will remove that type of login data and use it in: https://github.com/Expensify/App/blob/58e257532290aa0228f1c668ed461a15f1b2b136/src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx#L135-L137 and the other similar cases.
The selector function is something like:
selector: (data) => {
return Object.fromEntries(
Object.entries(data).filter(
([key, value]) => value.partnerName !== 'chat-expensify-com'
)
);
},
partnerName !== 'chat-expensify-com'
to filter the login data. We can also use partnerID
if this prop to filter.Happening to my account too
Hey @RachCHopkins. tagging you here as you pointed out that this is occurring for real customers.
Going to raise in Slack to find out what the expected behavior is here.
@nkuoch I see you added getting the loginlist in Auth a couple weeks ago here.
It seems like that is most likely the cause of this issue as it seems like Login::getList
is including these expensify.cash- logins. So we probably need to either filter them out after getting the results or write a different query that doesn't get these. What do you think?
@nkuoch Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Looks like the fix for this was merged and deployed. And it looks like it's working correctly. Thanks @nkuoch!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.6-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): dave0123seife@gmail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team
Action Performed:
Expected Result:
Ony added contact methods are displayed in contact methods
Actual Result:
Ony added contact methods are displayed in contact methods
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/0827306f-b014-4d0d-a17d-547535b921d6
View all open jobs on GitHub