search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.54k stars 2.88k forks source link

Chronos OOO reply isn't visible until re-opening the report #45343

Open m-natarajan opened 4 months ago

m-natarajan commented 4 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.6-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856

OOO.log

Expensify/Expensify Issue URL: Issue reported by: @neil-marcellini Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1720731749613299

Action Performed:

  1. Log in with an expensify account
  2. Message chronos "ooo 7/7/2029 for 1 day"

Expected Result:

Chronos replies after a little while

Actual Result:

You get a notification of the reply on another device, but the message isn't visible on the active device until you open another report, then re-open the Chronos report

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/fe0c672c-1e89-4800-b036-66ff7f4bbe5a

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @neil-marcellini
melvin-bot[bot] commented 4 months ago

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

joekaufmanexpensify commented 4 months ago

Discussing.

joekaufmanexpensify commented 4 months ago

Reproduced!

joekaufmanexpensify commented 4 months ago

@neil-marcellini I see you assigned, so gonna make this internal, as I think Chronos issues need to be internal. But LMK if that is not correct!

joekaufmanexpensify commented 3 months ago

Nothing BZ related to do here, so dropping off per our slack discussion. LMK if anything comes up that I can help with!

melvin-bot[bot] commented 3 months ago

@neil-marcellini this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

muttmuure commented 3 months ago

Is this a CRITICAL issue?

neil-marcellini commented 2 months ago

Not a priority, maybe someday

neil-marcellini commented 1 month ago

I'm still kicking this one down the road. I'm working on Chronos offline time tracking first.

neil-marcellini commented 2 weeks ago

I'll see if I can squeeze this in today

neil-marcellini commented 2 weeks ago

I investigated this a little bit. Here's what I've found so far:

App does not receive the Chronos response message in the response Onyx data for ooo messages. It does receive the Chronos response message for time messages like start/stop.

Timer actions processed by the Hours plugin respond in Auth and notifyParticpantsForActions is called from Web-E.

The OutOfOffice plugin returns the Chronos confirmation message as a raw string, and then Chronos calls sendMessage which calls addComment.

So for some reason the Chronos reply isn't pushed by Auth AddComment. Next I need to figure out why and queue the Onyx update in Auth.

neil-marcellini commented 1 week ago

I verified that Auth is queueing the Onyx update for the ooo reply message, and it's returned to Web-E in the Onyx data of the Auth response, and it seems to be queued with Pusher here. However, App isn't getting the Push event. I'll need to dig in further.