Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.29k stars 2.72k forks source link

Report containing only pending transactions displays a GBR next to the workspace chat #45363

Closed youssef-lr closed 1 month ago

youssef-lr commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

Action Performed:

  1. Create a report with a pending transaction in a Collect workspace

Expected Result:

No GBR shown next to the workspace chat of the approver as there is no action to take

Actual Result:

GBR is shown.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Screenshot 2024-07-13 at 02 08 06

Add any screenshot/video evidence

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

youssef-lr commented 1 month ago

I worked on this in a previous PR and I did a check wrong. Fixing it now and also adding tests.

twisterdotcom commented 1 month ago

Nice! PR is happening above.

twisterdotcom commented 1 month ago

@youssef-lr this was deployed to Auth right? We're done here aren't we?