Closed lanitochka17 closed 1 month ago
Triggered auto assignment to @mallenexpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-vsp
Concierge chat name and icon changes to the self DM one if the page is refreshed on workspace settings page. Affects Gmail and expensifail accounts too. It reverts to the default one if the chat is clicked
When we reload the page and call API OpenApp
, we'll get 2 participants in the Concierge chat
But currently, we don't consider Concierge as a Participants and it will be filtered
So the Concierge chat will have only one participant (current user)
We'll not filter participants when it is Concierge chat https://github.com/Expensify/App/blob/cf34d8706562426ed422e70bc43e26d0c69b05fa/src/libs/migrations/Participants.ts#L54
if (deprecatedParticipants.has(accountID) || accountID === currentUserAccountID || isConciergeChatReport(report)) {
Thanks @daledah , I'm checking on internally, we have quite a few report.participants
issues now, we might want to fix them holistically (or.. add them to a tracking issue since we might not need separate fixes for each one).
Job added to Upwork: https://www.upwork.com/jobs/~01075d42013d493c4a
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External
)
@eh2077 , do you think this can be external?
@mallenexpensify Yeah, I think so
@daledah Thanks for your proposal!
I can't reproduce it using existing account. Can you explain why this only happens with new account?
@eh2077 @mallenexpensify I can't reproduce now maybe this PR has fixed this issue
I also can't reproduce it.
@mallenexpensify Should we just close it?
@lanitochka17 This issue isn't reproducible anymore. Can you help to confirm?
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
Let's give it one pass for QA to try to repro then we'll close if they can't. Thanks @eh2077 and @daledah for the help here
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@mallenexpensify @eh2077 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Not overdue, we're waiting for QA to test it again
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Issue not reproducible during KI retests. (First week)
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.6-8 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Concierge chat name and icon should be the default one
Actual Result:
Concierge chat name and icon changes to the self DM one if the page is refreshed on workspace settings page. Affects Gmail and expensifail accounts too. It reverts to the default one if the chat is clicked
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/5a48eeb4-5176-41ad-b848-981d5d87c6d6
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @eh2077