Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.3k stars 2.73k forks source link

Only part of the expense got reimbursed and other shows as `company spend` #45441

Closed m-natarajan closed 3 weeks ago

m-natarajan commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): @danielrvidal and @justinpersaud Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @danielrvidal Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1720814827140919

Action Performed:

(There are no clear reproduction steps)

  1. User A submitted a report to user B in a workspace
  2. When submitting edit some of the cash amount which exceeds the limit or update merchant name which are illegible
  3. User B approves and reimburses all the expenses

Expected Result:

All the cash expenses in the report should be reimbursed (here it is $166.91)

Actual Result:

But the report is showing $96.45 of out of pocket spend, and $70.47 of company spend.

created,transactionID,cardID,reportID,receiptID,amount,merchant,mcc,state,comment,tag,externalID,memo,inserted,currency,modifiedCreated,modifiedAmount,modifiedMerchant,modifiedMCC,category,transactionHash,modifiedCurrency 2024-06-21,6460390883916703325,9943119,7483703546324104,3970764328544415,0,(none),"",3,,People,"",,"2024-06-21 23:57:44",CAD,2024-06-21,-1000,"Myung Dong Kal Kuk Su",,"Employee Office Meals",hash01B5D273EA9ED5FE1A7DCC6A0A7148F3C00A7EA4,USD 2024-06-22,7275952262581634356,9943119,7483703546324104,5115369232947914,0,(none),"",3,,People,"",,"2024-06-22 17:09:52",CAD,2024-06-22,-1000,"Evana Patisserie & Cafe",,"Employee Office Meals",hash9798DF5871D0C714A812AEDF10E74D2B56C5C11E,USD 2024-06-24,5750397947090045234,9943119,7483703546324104,4777862836218067,0,(none),"",3,,People,"",,"2024-06-24 15:25:31",CAD,2024-06-24,-1000,"MYSTIC MUFFIN",,"Employee Office Meals",hash25E7FAA7C8AB211CDBCBE15D0195F3B5DA5F2327,USD 2024-06-26,9055110650519140440,9943119,7483703546324104,2066319432944066,0,(none),"",3,,People,"",,"2024-06-27 00:50:28",USD,,-1000,"Owl of Minerva",,"Employee Office Meals",hash4C0FF8CDF3FC27DCC1E7D21596E9A55838293D58,USD 2024-06-27,83452543805693648,9943119,7483703546324104,438219964251047,0,(none),"",3,,People,"",,"2024-06-27 17:59:04",USD,2024-06-27,-1000,"DEER GARDEN SIGNATURES",,"Employee Office Meals",hash9A8A6ECCADCA6C2955F4818658B65A7D23E53A31,USD 2024-06-28,1260251282534266610,9943119,7483703546324104,7016407286772983,0,(none),"",3,,People,"",,"2024-06-29 00:22:21",USD,2024-06-28,-1000,"Costco Wholesale",,"Employee Office Meals",hashA6ABF0F3DF901E79DBBF3FC2DEDD89D8A8B7615B,USD 2024-06-29,1339236351537984370,9943119,7483703546324104,5651045403200488,0,(none),"",3,,People,"",,"2024-06-29 16:47:31",USD,2024-06-29,-1000,"Hoho Korean Food Inc",,"Employee Office Meals",hash6A85D015FE8425B9E73B190ADB3C81747AD23AE4,USD 2024-06-30,3784516516620607288,9943119,7483703546324104,8642158834847755,0,(none),"",3,,People,"",,"2024-06-30 22:48:19",USD,2024-06-30,-1076,WINNERS,,"Employee Office Meals",hash109B7B28B4DD0FAE07DE34548422AE662EFBF3E4,CAD 2024-07-01,4274979036192436768,9943119,7483703546324104,8490225820309126,0,(none),"",3,,People,"",,"2024-07-01 19:31:29",USD,2024-07-01,-1000,"Saint Germain Bakery Hillcrest Mall",,"Employee Office Meals",hash83E97BC58DAC6C33FF5FC3FA6E3FFD1C5B4F0A06,USD 2024-07-03,7745860180073536366,9943119,7483703546324104,8229051923136759,0,(none),"",3,,People,"",,"2024-07-03 12:40:13",USD,2024-07-03,-1175,Starbucks,,"Employee Office Meals",hashDE9B2EC86AD11244F7A3A000E699F5542FC82E82,CAD 2024-07-04,4511629833525667173,9943119,7483703546324104,3713862127706326,0,(none),"",6,,People,"",,"2024-07-05 00:12:37",USD,2024-07-04,-1000,"J.SAN SUSHI & MARKET",,"Employee Office Meals",hashD775B8D1BCD690135EECAE4FB2500BB802282BAB,USD 2024-07-06,5547144082480888915,9943119,7483703546324104,1667231795670677,0,(none),"",6,,People,"",,"2024-07-06 15:55:08",USD,"2024-07-05 15:38:10",-1000,Costco,,"Employee Office Meals",hashF242F11A9015557516055376C15F1581B51F514C,USD 2024-07-06,5504117521003103340,9943119,7483703546324104,5079711471426244,0,(none),"",6,,People,"",,"2024-07-06 20:36:54",USD,2024-07-06,-1000,"Swiss Chalet",,"Employee Office Meals",hashE6D0EB0DC057361E1CE8D3D8D83C7CF01803F887,USD 2024-07-07,6535081741122449809,9943119,7483703546324104,7727046275538746,0,(none),"",6,,People,"",,"2024-07-07 15:15:26",USD,2024-07-07,-1000,"Farm Boy",,"Employee Office Meals",hash87EC3B5C2CE3A4880AF0F07C01AE5D33AAAB8899,USD 2024-07-08,1217134905918151554,9943119,7483703546324104,5989762038516987,0,(none),"",6,,People,"",,"2024-07-09 00:27:12",USD,,-1000,Costco,,"Employee Office Meals",hash328921B51EFCD874452D094DB168AF51CEA4067E,USD 2024-07-09,33708026563348506,9943119,7483703546324104,5141887160143674,0,(none),"",6,,People,"",,"2024-07-09 12:14:57",USD,2024-07-09,-1000,Starbucks,,"Employee Office Meals",hashDAB9F522E5D0686D191E3CCE3343880BF4AC5AC3,USD 2024-07-11,7445522572402126748,9943119,7483703546324104,2244722235255437,0,(none),"",6,,People,"",,"2024-07-11 12:31:03",USD,2024-07-11,-1424,"Unknown Merchant",,"Employee Office Meals",hashD01C38D4D43FC831FA5748B4C3C97A2BA6CA2028,CAD

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/aa204bf6-f94e-4f00-ba9d-85c2ef662a0f

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

MelvinBot commented 1 month ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

adelekennedy commented 1 month ago

I think this one likely needs to be made internal but asking in thread

trjExpensify commented 1 month ago

Might be pending/scanning related. CC: @grgia for vis

melvin-bot[bot] commented 1 month ago

@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

adelekennedy commented 1 month ago

waiting for this one to get picked up - would love your 👁️ @grgia!

melvin-bot[bot] commented 1 month ago

@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

adelekennedy commented 1 month ago

waiting for an internal engineer to pick it up

melvin-bot[bot] commented 1 month ago

@adelekennedy this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

adelekennedy commented 1 month ago

still pending an internal engineer

melvin-bot[bot] commented 1 month ago

@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

adelekennedy commented 1 month ago

still waiting

trjExpensify commented 4 weeks ago

@adelekennedy any chance you could retest this one? @danielrvidal @justinpersaud have you come across this again?

trjExpensify commented 3 weeks ago

Bump on the retest! :)

justinpersaud commented 3 weeks ago

Sorry, missed the first ping.

I have not had this happen again.

danielrvidal commented 3 weeks ago

I have not either!

adelekennedy commented 3 weeks ago

I haven't been able to reproduce it 😬

trjExpensify commented 3 weeks ago

Cool, closing!