Closed m-natarajan closed 1 week ago
Triggered auto assignment to @techievivek (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
Triggered auto assignment to @abekkala (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
:wave: Friendly reminder that deploy blockers are time-sensitive β± issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
iOS - Search - Empty modal is shown when tapping on "0 selected" dropdown
Modal is set to true even if itemsLength
is 0.
https://github.com/Expensify/App/blob/7d58aa6694f8ef6eb298c35526a154f7e374fdd6/src/pages/Search/SearchSelectedNarrow.tsx#L50
Return from the function without calling openMenu();
if itemsLength
is 0.
onPress={() => {
if (!itemsLength) {
return;
}
openMenu();
}}
Instead of returning empty options when selectedItemsKeys.length === 0
is true, we can add some content to display that no options is selected, it can be done the same way we do when options length is 0.
https://github.com/Expensify/App/blob/7d58aa6694f8ef6eb298c35526a154f7e374fdd6/src/components/Search/SearchPageHeader.tsx#L49-L53
https://github.com/Expensify/App/blob/7d58aa6694f8ef6eb298c35526a154f7e374fdd6/src/components/Search/SearchPageHeader.tsx#L101-L117
iOS - Search - Empty modal is shown when tapping on "0 selected" dropdown
We don't set isMobileSelectionModeActive
as false when selected Items is empty on SearchListWithHeader.tsx
page
We will set isMobileSelectionModeActive as false on this page, if the selected items are cleared with a useEffect:
useEffect(() => {
if (isEmptyObject(selectedItems)){
setIsMobileSelectionModeActive?.(false);
}
}, [selectedItems])
This would remove the checkmarks from the screen as the user would be expecting when they are trying deselect everything.
<Button
...
isDisabled={options.length === 0}
shouldShowRightIcon={options.length !== 0}
/>
SearchSelectedNarrow
if there are no dropdown options by early returning in here:
if (options.length === 0) {
return null;
}
or update: https://github.com/Expensify/App/blob/7d58aa6694f8ef6eb298c35526a154f7e374fdd6/src/pages/Search/SearchSelectedNarrow.tsx#L49-L57 to:
<Button
...
style={[styles.w100, styles.ph5, options.length === 0 && {opacity: 0}]}
isDisabled={options.length === 0}
/>
Alternative solution 1 | Alternative solution 2 |
---|---|
Will take this over since Vivek is offline
This was added from a recent PR since it's not reproducible on production right? Was someone able to find the linked PR?
Thanks for the proposals everyone!
@dominictb's main proposal looks good to me. The disabling of the button is a more common pattern that we usually make use of in our app.
@dominictb Can you create the PR real quick since this is a deploy blocker?
π π π C+ reviewed
Current assignee @thienlnam is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
We're going with @dominictb's proposal, and will spin up the PR since you're offline - we'll still compensate you
@thienlnam Thanks for creating a quick PR. I am not online at that time.
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.7-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-24. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.8-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-25. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
@dominictb payment sent and contract ended - thank you! π
Pre-req: Make sure that the user has at least one expense.
Verify that there should not be any dropdown when no expense is selected
Do we π or π ?
$250 approved for @allroundexperts
Re-opening for the regression test.
QA GH for regression test created.
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.7- 4 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: n/a Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: applause internal team Slack conversation:
Action Performed:
Precondition:
Expected Result:
There should not be any dropdown when no expense is selected.
Actual Result:
There is a "0 selected" dropdown when no expense is selected, which opens an empty modal when tapped.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
https://github.com/user-attachments/assets/863c209c-a67b-46d7-9ed6-7910fcb4b5e9
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @abekkala