[HOLD for payment 2024-07-24] iOS - Search - Empty modal is shown when tapping on "0 selected" dropdown

m-natarajan commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.7- 4 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: n/a Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: applause internal team Slack conversation:

Action Performed:

Precondition:

User has at least one expense.

Launch New Expensify app.
Go to Search.
Long tap on any expense.
Tap Select.
Unselect the selected expense.
Tap "0 selected".

Expected Result:

There should not be any dropdown when no expense is selected.

Actual Result:

There is a "0 selected" dropdown when no expense is selected, which opens an empty modal when tapped.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/863c209c-a67b-46d7-9ed6-7910fcb4b5e9

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @abekkala

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 1 month ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Krishna2323 commented 1 month ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Search - Empty modal is shown when tapping on "0 selected" dropdown

What is the root cause of that problem?

Modal is set to true even if itemsLength is 0. https://github.com/Expensify/App/blob/7d58aa6694f8ef6eb298c35526a154f7e374fdd6/src/pages/Search/SearchSelectedNarrow.tsx#L50

What changes do you think we should make in order to solve the problem?

Return from the function without calling openMenu(); if itemsLength is 0.

                onPress={() => {
                    if (!itemsLength) {
                        return;
                    }
                    openMenu();
                }}

What alternative solutions did you explore? (Optional)

Instead of returning empty options when selectedItemsKeys.length === 0 is true, we can add some content to display that no options is selected, it can be done the same way we do when options length is 0. https://github.com/Expensify/App/blob/7d58aa6694f8ef6eb298c35526a154f7e374fdd6/src/components/Search/SearchPageHeader.tsx#L49-L53 https://github.com/Expensify/App/blob/7d58aa6694f8ef6eb298c35526a154f7e374fdd6/src/components/Search/SearchPageHeader.tsx#L101-L117

neonbhai commented 1 month ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Search - Empty modal is shown when tapping on "0 selected" dropdown

What is the root cause of that problem?

We don't set isMobileSelectionModeActive as false when selected Items is empty on SearchListWithHeader.tsx page

What changes do you think we should make in order to solve the problem?

We will set isMobileSelectionModeActive as false on this page, if the selected items are cleared with a useEffect:

useEffect(() => {
    if (isEmptyObject(selectedItems)){
        setIsMobileSelectionModeActive?.(false);
    } 
}, [selectedItems])

This would remove the checkmarks from the screen as the user would be expecting when they are trying deselect everything.

dominictb commented 1 month ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is a "0 selected" dropdown when no expense is selected, which opens an empty modal when tapped.

What is the root cause of that problem?

This button is always interactive even if there are no dropdown options to display: https://github.com/Expensify/App/blob/7d58aa6694f8ef6eb298c35526a154f7e374fdd6/src/pages/Search/SearchSelectedNarrow.tsx#L49-L57
When there is no selected item, so there is no dropdown options, press on it still open modal.
What changes do you think we should make in order to solve the problem?
We should disable that button if there is no dropdown options: https://github.com/Expensify/App/blob/7d58aa6694f8ef6eb298c35526a154f7e374fdd6/src/pages/Search/SearchSelectedNarrow.tsx#L49-L57
```
        <Button
            ...
            isDisabled={options.length === 0}
            shouldShowRightIcon={options.length !== 0}
        />
```
Result

What alternative solutions did you explore? (Optional)

We can hide the SearchSelectedNarrow if there are no dropdown options by early returning in here:
```
if (options.length === 0) {
    return null;
}
```
or update: https://github.com/Expensify/App/blob/7d58aa6694f8ef6eb298c35526a154f7e374fdd6/src/pages/Search/SearchSelectedNarrow.tsx#L49-L57 to:
```
        <Button
            ...
            style={[styles.w100, styles.ph5, options.length === 0 && {opacity: 0}]}
            isDisabled={options.length === 0}
        />
```

Result

Alternative solution 1	Alternative solution 2

thienlnam commented 1 month ago

Will take this over since Vivek is offline

thienlnam commented 1 month ago

This was added from a recent PR since it's not reproducible on production right? Was someone able to find the linked PR?

allroundexperts commented 1 month ago

Thanks for the proposals everyone!

@dominictb's main proposal looks good to me. The disabling of the button is a more common pattern that we usually make use of in our app.

@dominictb Can you create the PR real quick since this is a deploy blocker?

🎀 👀 🎀 C+ reviewed

melvin-bot[bot] commented 1 month ago

Current assignee @thienlnam is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

thienlnam commented 1 month ago

We're going with @dominictb's proposal, and will spin up the PR since you're offline - we'll still compensate you

dominictb commented 1 month ago

@thienlnam Thanks for creating a quick PR. I am not online at that time.

melvin-bot[bot] commented 1 month ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.7-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/45535

If no regressions arise, payment will be issued on 2024-07-24. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@allroundexperts requires payment through NewDot Manual Requests
@dominictb requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 1 month ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@allroundexperts] Determine if we should create a regression test for this bug.
[ ] [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

abekkala commented 1 month ago

PAYMENT SUMMARY FOR JULY 24

Fix: @dominictb [$250, if no regressions] offer
PR Review: @allroundexperts [$250, if no regressions] payment via NewDot Please complete checklist

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.8-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/45535

If no regressions arise, payment will be issued on 2024-07-25. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@allroundexperts requires payment through NewDot Manual Requests
@dominictb requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 1 month ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@allroundexperts] Determine if we should create a regression test for this bug.
[ ] [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

abekkala commented 1 month ago

PAYMENT SUMMARY FOR JULY 24

Fix: @dominictb [$250, if no regressions] offer
PR Review: @allroundexperts [$250, if no regressions] payment via NewDot Please complete checklist

abekkala commented 1 month ago

@dominictb payment sent and contract ended - thank you! 🎉

allroundexperts commented 1 month ago

Checklist

https://github.com/Expensify/App/pull/44820
https://github.com/Expensify/App/pull/44820/files#r1694343462
N/A
A regression test would be a nice addition.

Regression Test

Pre-req: Make sure that the user has at least one expense.

Open the app, go to Search
Long tap on any expense and press Select
Unselect the selected expense
Tap "0 selected"

Verify that there should not be any dropdown when no expense is selected

Do we 👍 or 👎 ?

JmillsExpensify commented 1 week ago

$250 approved for @allroundexperts

JmillsExpensify commented 1 week ago

Re-opening for the regression test.

abekkala commented 1 week ago

QA GH for regression test created.

Expensify / App