[HOLD for payment 2024-10-22] [$250] Web/Desktop - Chat - Focus is lost after deleting a message from edit mode

lanitochka17 commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.7-4 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4725448 Email or phone of affected tester (no customers): fischer9966@gmail.com Issue reported by: Applause - Internal Team

Action Performed:

Start ND on Desktop App or go to staging.new.expensify.com
Login with any account
Open any chat and send a message
Press Arrow Up key on keyboard
Select All - Ctrl / Cmd + A
Press 'Delete' key
Press 'Enter' key
Confirm message deletion with 'Enter' key

Expected Result:

Message deleted. Focus is on composer field

Actual Result:

Focus lost after deleting message in edit mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/67231f2f-46a8-4f10-93cf-7389de640c18

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fe43add27dc504ef
Upwork Job ID: 1826277990269229690
Last Price Increase: 2024-09-18
Automatic offers:

brunovjk | Reviewer | 104052891

Issue Owner

Current Issue Owner: @brunovjk

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] commented 1 month ago

📣 @brunovjk 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] commented 1 month ago

📣 @Shahidullah-Muffakir You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

Shahidullah-Muffakir commented 1 month ago

I will submit the PR within 24hrs.

brunovjk commented 1 month ago

PR under review.

melvin-bot[bot] commented 3 weeks ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 3 weeks ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.48-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/49538

If no regressions arise, payment will be issued on 2024-10-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@brunovjk requires payment automatic offer (Reviewer)
@Shahidullah-Muffakir requires payment (Needs manual offer from BZ)

brunovjk commented 2 weeks ago

BugZero Checklist:

[x] [@brunovjk] The PR that introduced the bug has been identified. Link to the PR: I couldn't find any changes or pull requests that would have caused this issue. According to the file history, those lines have remained unchanged since the file was created.
[x] [@brunovjk] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: The change updated the code by directly assigning the result of runAndResetCallback() to callbackWhenDeleteModalHide.current, eliminating unnecessary indirection and making the behavior more predictable.
[x] [@brunovjk] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[x] [@brunovjk] Determine if we should create a regression test for this bug. Yes
[x] [@brunovjk] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Start the ND Desktop App or go to staging.new.expensify.com and log in with any account.
Open any chat and send a message.
Press the Arrow Up key, then use Ctrl + A (or Cmd + A) to select all text, followed by the 'Delete' key.
Press 'Enter' to confirm the deletion.
Ensure that the focus remains on the composer field after deletion.

Do we agree 👍 or 👎?

cc: @youssef-lr, @johnmlee101

melvin-bot[bot] commented 2 weeks ago

Issue is ready for payment but no BZ is assigned. @joekaufmanexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!