Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.53k stars 2.88k forks source link

[$250] mWeb - Room - Whisper is not shown for mention added while edit comment #45496

Closed lanitochka17 closed 1 month ago

lanitochka17 commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.7 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4724888 Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap on a room report
  3. Enter jaihanumanblog@gmail.com

    567 (email id and random room mention)

  4. Send the message
  5. Note whisper message is shown
  6. Long press the comment and select edit comment
  7. Enter jaihanumanblog+6788@gmail.com

    56778 (email id and random room mention)

  8. Send the message

Expected Result:

Whisper must be shown for mention added while edit comment

Actual Result:

Whisper is not shown for mention added while edit comment

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/f7964cbb-e3c8-4692-9823-66d87b2f4e5b

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01490add6334f2b67a
  • Upwork Job ID: 1813353966729699916
  • Last Price Increase: 2024-07-16
Issue OwnerCurrent Issue Owner: @marcochavezf
melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 3 months ago

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 3 months ago

We think that this bug might be related to #vip-vsp

JmillsExpensify commented 3 months ago

Yes, that's correct. Opening up to the community.

melvin-bot[bot] commented 3 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01490add6334f2b67a

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

Tony-MK commented 3 months ago

@JmillsExpensify and @suneox, I believe this issue should handled in the back end because the updateComment response does not include the "ACTIONABLEREPORTMENTIONWHISPER" action like the AddComment response.

Could we check this in the back end?

Thanks

suneox commented 3 months ago

@JmillsExpensify and @suneox, I believe this issue should handled in the back end because the updateComment response does include the "ACTIONABLEREPORTMENTIONWHISPER" action like the AddComment response.

@Tony-MK Thank you for your investigate, I'll be check in few hours

suneox commented 3 months ago

I have double-checked that the updateComment API doesn’t update the message content for actionName is ACTIONABLEREPORTMENTIONWHISPER. Therefore, I think this issue should be moved to internal.

🎀 👀 🎀 C+ reviewed

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

suneox commented 3 months ago

Not overdue, still waiting for an internal fix

marcochavezf commented 3 months ago

No update, I will move to weekly since it's vip-vsb and low

melvin-bot[bot] commented 3 months ago

@JmillsExpensify @marcochavezf @suneox this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

marcochavezf commented 3 months ago

No update, addressing other high priority items this week

marcochavezf commented 2 months ago

I will check it out today or tomorrow, I will move it to daily meanwhile

melvin-bot[bot] commented 2 months ago

@JmillsExpensify, @marcochavezf, @suneox Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

marcochavezf commented 2 months ago

Sorry, no update. I've been caught up with other priorities.

suneox commented 2 months ago

This issue will be handled by the internal team, so I’d like to self-unassign

marcochavezf commented 2 months ago

Moving it back to weekly

marcochavezf commented 2 months ago

No update, addressing other higher priority issues

marcochavezf commented 1 month ago

No update

marcochavezf commented 1 month ago

Not a priority, unassigning myself for now

JmillsExpensify commented 1 month ago

Just going to close if this isn't a priority.