Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.58k stars 2.92k forks source link

[HOLD for payment 2024-08-01] Sage Intacct- "Entity" menu is empty and can not be navigated in Sage Intacct #45514

Closed lanitochka17 closed 3 months ago

lanitochka17 commented 4 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.7-4 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

The user has a workspace policy connected to Sage Intacct

  1. Navigate to Workspace settings > Accounting
  2. Go to the "Entity" menu

Expected Result:

The user can navigate to the "Entity" page and change the entity

Actual Result:

The "Entity" menu is empty and cannot be navigated

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/1d7aef70-caee-406a-bcb4-210e48c1d472

View all open jobs on GitHub

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 4 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
puneetlath commented 4 months ago

This is under beta, so demoting from being a deploy blocker.

war-in commented 4 months ago

Hi 👋 It seems that the backend returned empty entities in data and that's why you can't navigate to them. I have some entities in my account and I can normally navigate to the page.

https://github.com/user-attachments/assets/521bbf9f-eca4-4618-a30d-7e30ca901697

puneetlath commented 4 months ago

@yuwenmemon going to assign this over to you. Hope you don't mind.

yuwenmemon commented 4 months ago

@NikkiWines Looks like this is an issue with the initial sync - can you take a look?

NikkiWines commented 4 months ago

AFAICT this isn't an issue with the initial sync, it's just that we show this option regardless of whether or not there are entities returned - I'll push up a change so that the menu option is only shown if there are actually entities to select.

melvin-bot[bot] commented 4 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 4 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.11-5 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-01. :confetti_ball:

melvin-bot[bot] commented 4 months ago

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

brunovjk commented 3 months ago

Just to confirm, @NikkiWines, is this message correct? I'm relatively new here, and I couldn't find information about paying for PR review without reviewing the issue/proposal first. Thanks a lot.

NikkiWines commented 3 months ago

No, in this case it's wrong, since you reviewed this PR you are eligible for compensations. The automation didn't catch it cause you weren't assigned to this issue. I'll add the appropriate labels so we can provide the appropriate comp

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

NikkiWines commented 3 months ago

@abekkala can we provide comp to @brunovjk since they reviewed my PR to fix this issue 🙇 thanks!

brunovjk commented 3 months ago

Good to know :D Thank you very much @NikkiWines

abekkala commented 3 months ago

PAYMENT SUMMARY:

abekkala commented 3 months ago

@brunovjk payment sent and contract ended- thank you! 🎉