Closed lanitochka17 closed 3 weeks ago
Triggered auto assignment to @alexpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Room - System message for clearing room description is copied differently
For UPDATE_ROOM_DESCRIPTION
type report action, there is an inconsistency between how the report action is displayed as in here
https://github.com/Expensify/App/blob/1465a9294f5ff357fb30f55c1e90df791c73cd29/src/pages/home/report/ReportActionItem.tsx#L652-L653
and how text is copied to clipboard
https://github.com/Expensify/App/blob/1465a9294f5ff357fb30f55c1e90df791c73cd29/src/pages/home/report/ContextMenu/ContextMenuActions.tsx#L366-L367
We need to copy to clipboard same as we are displaying the UPDATE_ROOM_DESCRIPTION
type report action as in here
https://github.com/Expensify/App/blob/1465a9294f5ff357fb30f55c1e90df791c73cd29/src/pages/home/report/ReportActionItem.tsx#L652-L653
by adding condition for UPDATE_ROOM_DESCRIPTION
type report action
here
https://github.com/Expensify/App/blob/1465a9294f5ff357fb30f55c1e90df791c73cd29/src/pages/home/report/ContextMenu/ContextMenuActions.tsx#L420-L421
else if (reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ROOM_CHANGE_LOG.UPDATE_ROOM_DESCRIPTION) {
const originalMessage = ReportActionsUtils.getOriginalMessage(reportAction);
const message = `${Localize.translateLocal('roomChangeLog.updateRoomDescription')} ${(originalMessage as OriginalMessageChangeLog)?.description}`;
Clipboard.setString(message);
}
We can also alternatively change what we are diplaying in ReportActionItem
to be the same as the cleared ..
message , which is the same as the value we use to copy to clipboard now as in here
https://github.com/Expensify/App/blob/1465a9294f5ff357fb30f55c1e90df791c73cd29/src/pages/home/report/ContextMenu/ContextMenuActions.tsx#L366-L367
so we can set the message
to it here
https://github.com/Expensify/App/blob/1465a9294f5ff357fb30f55c1e90df791c73cd29/src/pages/home/report/ReportActionItem.tsx#L651-L653
The room description system message is "set the room description to: " The copied content is "cleared the room description"
We always display the message set the room description to:
in LHN and report action even we clear the description.
We should display the cleared message like the message that is returned by BE if the description is empty
function getUpdateRoomDescriptionMessage(reportAction: ReportAction): string {
const originalMessage = getOriginalMessage(reportAction) as OriginalMessageChangeLog;
if (originalMessage.description) {
return `${Localize.translateLocal('roomChangeLog.updateRoomDescription')} ${originalMessage?.description}`;
}
return Localize.translateLocal('roomChangeLog.clearRoomDescription');
}
const message = ReportActionsUtils.getUpdateRoomDescriptionMessage(action);
result.alternateText = `${lastActorDisplayName} ${ReportActionsUtils.getUpdateRoomDescriptionMessage(lastAction)};
OPTIONAL: We can also add the case for update room description in context menu action. So the copied message can be translated
NA
Other GHs have been a priority, I'll review soon
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External
)
@hungvu193 - can you review if one of these proposals will fix this problem? Thanks!
Sure thing. I'll review today
I lean toward to @nkdengineer 's proposal here. We should display clear the room description
instead of unformatted message.
🎀 👀 🎀 C+ reviewed
Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.13-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-05. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.14-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-07. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Noted that the payment date is on August 7
Job added to Upwork: https://www.upwork.com/jobs/~01db9b6412780cbcba
Current assignee @hungvu193 is eligible for the External assigner, not assigning anyone new.
@nkdengineer - please accept the invite in Upwork and I can complete the payment process - Thanks!
https://github.com/Expensify/App/issues/45522#issuecomment-2274038463
Regression test:
Do we 👍 or 👎 ?
There is no update; waiting for @nkdengineer to accept the Upwork invite before I can close this GH.
No update
@alexpensify I accepted the offer, thanks
I'm all set here. I've completed the payment process in Upwork. I'll return later this week to complete the regression test.
https://github.com/Expensify/App/issues/45522#issuecomment-2274038463
$250 approved for @hungvu193
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.7-4 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4728014 Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The copied content should be consistent with the room description system message
Actual Result:
The room description system message is "set the room description to: " The copied content is "cleared the room description"
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/4763fc8e-ec8c-4a18-8e65-957a5109bcaf
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @Upwork Automation - Do Not Edit