Open m-natarajan opened 1 month ago
Triggered auto assignment to @strepanier03 (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@strepanier03 Huh... This is 4 days overdue. Who can take care of this?
@strepanier03 Still overdue 6 days?! Let's take care of this!
Working on this now, sorry for the delay.
What timing, I have a chat that follows this pattern in my LHN right now that showed up this morning 😂. There's no way to dismiss it and it's stuck with a RBR in my LHN all day so far.
Mac/Chrome
Here's the Onyx Data for that chat:
{
"chatType": "",
"currency": "USD",
"description": "",
"hasOutstandingChildRequest": false,
"hasOutstandingChildTask": false,
"isCancelledIOU": false,
"isOwnPolicyExpenseChat": false,
"isPinned": false,
"isWaitingOnBankAccount": false,
"lastActionType": "CREATED",
"lastActorAccountID": 17680685,
"lastMessageHtml": "hi",
"lastMessageText": "hi",
"lastReadSequenceNumber": 0,
"lastVisibleActionCreated": "2024-06-26 08:59:07.758",
"lastVisibleActionLastModified": "2024-06-26 08:56:07.301",
"managerID": 0,
"nonReimbursableTotal": 0,
"notificationPreference": "always",
"oldPolicyName": "",
"ownerAccountID": 0,
"participants": {
"2644835": {
"hidden": false
},
"17680685": {
"hidden": false
}
},
"permissions": [
"read",
"write"
],
"policyID": "_FAKE_",
"reportID": "3860266512989981",
"reportName": "Chat Report",
"stateNum": 0,
"statusNum": 0,
"total": 0,
"type": "chat",
"unheldTotal": 0,
"welcomeMessage": "",
"writeCapability": "all",
"isEdited": false,
"errorFields": {
"notFound": {
"1720457339876689": "Report not found",
"1720478844867650": "Report not found",
"1721845816001669": "Report not found",
"1721845828999863": "Report not found",
"1721845837355611": "Report not found",
"1721846910100562": "Report not found"
}
},
"lastReadTime": "2024-07-08 22:47:30.782"
}
Job added to Upwork: https://www.upwork.com/jobs/~016fe03af3d662fd8f
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External
)
You see a Hmmm it's not here, but the report is stuck in your LHN with a red dot (RBR indicator), and can't be cleared.
After the user is removed from the room, the report data is still present in Onyx and it has a not found
error when the removed user clicks on the room again.
That makes hasErrorsOtherThanFailedReceipt
is true
https://github.com/Expensify/App/blob/b0f810df06c3df866b7fdbed4959f8f1fef803ed/src/libs/SidebarUtils.ts#L123-L127
And then here we always put this report in LHN if hasErrorsOtherThanFailedReceipt
is true
https://github.com/Expensify/App/blob/b0f810df06c3df866b7fdbed4959f8f1fef803ed/src/libs/SidebarUtils.ts#L130-L136
So this report is always displayed in LHN
We should check if the report has not found an error we will not push this report here.
if (hasErrorsOtherThanFailedReceipt && !report?.errorFields?.notFound) {
Then when we go to shouldReportBeInOptionList
check, it already has the check to return false if the report is not found
https://github.com/Expensify/App/blob/b0f810df06c3df866b7fdbed4959f8f1fef803ed/src/libs/ReportUtils.ts#L5531-L5533
@strepanier03 @nkdengineer I cannot reproduce the issue, I followed the steps and the result on my side is:
Note: The room was freshly created when I attempted reproducing.
Here's a video of how it looks on my side:
To me ^ this looks like the correct and expected behaviour, meaning: silently being removed, without any Not found page being shown or RBR errors.
If anyone has clear / more detailed steps as to how this can be consistently reproduced, please let me know so we can move forward with a fix.
Otherwise, I'd add the Needs Reproduction
label and have a few other prople try reproducing this and if no dice then close as non-reproducible (probably BE pusher event related [not removing the data correctly from {Bob}]).
cc @roryabraham (since you reported this)
@strepanier03 are you still able to reproduce this?
I can't reproduce it now. Yesterday, when the user was removed, the user didn't receive any pusher data so we can reproduce this bug. But now, the pusher data clears the report data and then this issue cannot be reproduced.
@strepanier03, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick!
Needs Reproduction
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@strepanier03 @ikevin127 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
@strepanier03, @ikevin127 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Needs Reproduction
- callback on https://github.com/Expensify/App/issues/45551#issuecomment-2251615629 / https://github.com/Expensify/App/issues/45551#issuecomment-2252048407.
@strepanier03, @ikevin127 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Needs Reproduction
- callback on https://github.com/Expensify/App/issues/45551#issuecomment-2251615629 / https://github.com/Expensify/App/issues/45551#issuecomment-2252048407.
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@strepanier03, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick!
Needs Reproduction
- callback on https://github.com/Expensify/App/issues/45551#issuecomment-2251615629 / https://github.com/Expensify/App/issues/45551#issuecomment-2252048407.
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@strepanier03 @ikevin127 this issue is now 4 weeks old, please consider:
Thanks!
@strepanier03, @ikevin127 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Needs Reproduction
- callback on https://github.com/Expensify/App/issues/45551#issuecomment-2251615629 / https://github.com/Expensify/App/issues/45551#issuecomment-2252048407.
@strepanier03, @ikevin127 Huh... This is 4 days overdue. Who can take care of this?
Needs Reproduction
- callback on https://github.com/Expensify/App/issues/45551#issuecomment-2251615629 / https://github.com/Expensify/App/issues/45551#issuecomment-2252048407.
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@strepanier03, @ikevin127 Huh... This is 4 days overdue. Who can take care of this?
Needs Reproduction - callback on https://github.com/Expensify/App/issues/45551#issuecomment-2251615629 / https://github.com/Expensify/App/issues/45551#issuecomment-2252048407.
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@strepanier03, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick!
Needs Reproduction
- callback on https://github.com/Expensify/App/issues/45551#issuecomment-2251615629 / https://github.com/Expensify/App/issues/45551#issuecomment-2252048407.
@strepanier03, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick!
Needs Reproduction
- callback on https://github.com/Expensify/App/issues/45551#issuecomment-2251615629 / https://github.com/Expensify/App/issues/45551#issuecomment-2252048407.
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.8-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @roryabraham Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721060374459769
Action Performed:
Expected Result:
You should see a
Hmmm it's not here
(404 error), then when you navigate away the report should disappear from the LHN.Actual Result:
You see a
Hmmm it's not here
, but the report is stuck in your LHN with a red dot (RBR indicator), and can't be cleared.Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
https://github.com/user-attachments/assets/5ffa4369-4240-4b89-bbb9-57e87bac6afe
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ikevin127