Closed m-natarajan closed 1 day ago
Triggered auto assignment to @kadiealexander (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #wave-collect - Release 2
Job added to Upwork: https://www.upwork.com/jobs/~01622f31aad5cbea6e
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External
)
"Account ending in" message appears after adding bank account for the card
After adding new bank account from Expensify Card page, the bankAccounts
onyx data given by the API not formatted properly and we didn't fetch the properly formatted bankAccounts
onyx data as we do in the wallet page
Add the following code after AcceptACHContractForBankAccount
API Write here to make sure we got the properly formatted bankAccounts
onyx data after adding new bank account from Expensify Card page
PaymentMethods.openWalletPage();
OR
API.read(READ_COMMANDS.OPEN_PAYMENTS_PAGE, null);
And need to update here to properly get the right bankName
and bankAccountOwnerName
, to make sure we displayed the bank icon
return eligibleBankAccounts.map((bankAccount) => {
const bankName = bankAccount.accountData?.additionalData?.bankName;
const bankAccountOwnerName = bankAccount.accountData?.addressName;
const formattedBankAccountNumber = bankAccount.accountData?.accountNumber
? `${translate('workspace.expensifyCard.accountEndingIn')} ${bankAccount.accountData?.accountNumber.slice(-4)}`
: '';
const {icon, iconSize, iconStyles} = getBankIcon({bankName, styles});
return (
<MenuItem
title={bankAccountOwnerName}
description={formattedBankAccountNumber}
onPress={handleSelectBankAccount}
icon={icon}
iconHeight={iconSize}
iconWidth={iconSize}
iconStyles={iconStyles}
shouldShowRightIcon
displayInDefaultIconColor
/>
);
});
AcceptACHContractForBankAccount
API response on BE to return the properly formatted bankAccountList
onyx dataRESULT
Account details not being correctly displayed after adding new account. The account's data is not being passed properly to the item in a list.
The eligibleBankAccounts mapping function that maps bankAccountList to menu items, is trying to use some values from bankAccount.accountData
which are not present in that object after adding the account.
For displaying the data in menu item we can use the values from bankAccountList
item iteself. So the proposed changes are next:
bankAccount
object, and not from bankAccount.accountData
.
bankAccount.description.slice(-4)
for the bankAccountNumber
variablebankAccount.title
for the Account Holder name in the menu itembankName
property is present directly in the accountData
object after adding a new account, we can add a conditional that will use the bankName
variable from accountData.bankName
, and if that is missing then use a value from accountData.additionalData.bankName
.bankName
can be present both in AccountData
type or the BankAccountAdditionalData
type, depending on the response that provides bankAccountList
.All of the above variables are already accessible in bankAccountList
items after adding a new account, so no additional fetching needed.
๐ฃ @VasylMartyniv! ๐ฃ Hey, it seems we donโt have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Contributor details Your Expensify account email: vasyl.martyniv@perfsol.tech Upwork Profile Link: https://www.upwork.com/freelancers/~018d00e8b30180eee9
โ Contributor details stored successfully. Thank you for contributing to Expensify!
@nyomanjyotisa
the
bankAccounts
onyx data given by the API not formatted properly
Can you elaborate how not formatted? (include returned data vs expected data)
@VasylMartyniv
trying to use some values from
bankAccount.accountData
which are not present in that object after adding the account
Why do we have missing fields? And are the rest of the fields returned by the backend or populated optimistically?
@s77rt, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!
Waiting on proposals
๐ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐ธ
@s77rt, @kadiealexander Eep! 4 days overdue now. Issues have feelings too...
Same ^
@s77rt I am still working on Expensify Card (Workspace Feed) project and I was working on the adding bank account logic. Maybe I could work on that?
๐ ๐ ๐ Please assign @koko57
Triggered auto assignment to @iwiznia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Shouldn't there be a proposal?
@iwiznia agency-employees are assigned immediately then a proposal is submitted
@iwiznia @s77rt @kadiealexander this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Not overdue. Waiting on proposal
I will be working on this today
I'm trying to reproduce the bug, but even with providing the data to skip the Verification wit Onfido, or trying to verify I can't get my account added to the bankAccount list. But I agree with previous proposals - it would be good to check why the bankAccount is not returned after adding it the same way the same bank account is then returned with openWalletPage
@iwiznia, @s77rt, @koko57, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!
No update yet. Still having issues reproducing this due to verification flow
I will investingate it today
posted my findings here: https://github.com/Expensify/App/issues/47239#issuecomment-2286312613
@iwiznia, @s77rt, @koko57, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Not overdue. Waiting on https://github.com/Expensify/App/issues/47239
@iwiznia @s77rt @koko57 @kadiealexander this issue is now 4 weeks old, please consider:
Thanks!
Same ^
@iwiznia, @s77rt, @koko57, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Same ^
@s77rt more explaination here: https://github.com/Expensify/App/issues/47239#issuecomment-2298836350
The issue with the data not being sent the same way is solved, but we still need to make one fix here.
We need to change bankAccount.accountData?.accountNumber
for bankAccount.accountData?.additionalData?.mask
and use the mask without additionally using getLastFourDigits
@koko57 Thanks! Let's wait for @mountiny on this one, for consistency I think we may want the accountNumber
@mountiny waiting for your decision here ๐ Personally I would go with changing this to mask
regardless if the accountNumber
is added or not, because we could get rid of getLastFourDigits
calculation and mask
is something that should be returned for every card
We should work on unifying how we send the data from those two commands, I created a task to do that here https://github.com/Expensify/App/issues/47944
I got a quick PR to add the masked accountNumber
to the response here too so we can keep the behaviour unified.
@mountiny should I make this change with mask that I proposed anyway? or are we going with just the backend fix?
Lets just wait for the backend fix so we do not handle this differently in two places
@iwiznia, @s77rt, @koko57, @mountiny, @kadiealexander Huh... This is 4 days overdue. Who can take care of this?
@koko57 the fix is deployed, can you retest it?
Not overdue
Follow up backend PR merged
@mountiny is there anything else left to complete on this issue?
@koko57 We had to make one small backend change and that should have been deployed. Can you please confirm if there is anything left to do for this one? Thank you ๐
it's working now - ending in number is displayed
cc @mountiny
If you havenโt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when validating #45388 Version Number: 9.0.9-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause Internal Team Slack conversation:
Action Performed:
Expected Result:
The account holders name and the accounts last four number should be showing.
Actual Result:
"Account ending in" message appears after adding bank account for the card. You have to relog for the correct info to load.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/6ad8a5a7-6e4c-48ba-91ff-c29784f21626
View all open jobs on GitHub
Upwork Automation - Do Not Edit