Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.29k stars 2.73k forks source link

[$250] Invitation emails are missing user mention #45736

Closed m-natarajan closed 1 month ago

m-natarajan commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.9-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @justinpersaud Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721314652125589

Action Performed:

  1. Create a new room
  2. Invite a new user to the room through the room member list
  3. The invited user should receive an email shortly after for the invitation

    Expected Result:

    The invitation email should match what is shown in the room "invited @username-goes-here"

    Actual Result:

    The email only says "invited"

    Workaround:

    Unknown

    Platforms:

    Which of our officially supported platforms is this issue occurring on?

    • [x] Android: Native
    • [x] Android: mWeb Chrome
    • [x] iOS: Native
    • [x] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (2) image (3) Snip - #test-new-roomemail - mnata utest@gmail com - Gmail - Google Chrome

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01185310fddc87e53a
  • Upwork Job ID: 1816965203731451586
  • Last Price Increase: 2024-07-26
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Christinadobrzyn commented 1 month ago

I'm not getting any invite emails to a test @gmail or @expensifail account. I tested both an existing and new customer.

image image image image
justinpersaud commented 1 month ago

That's weird. I think you're supposed to be notified immediately for invitations.

Christinadobrzyn commented 1 month ago

Yeah, I thought I've received those before which is why I tried with an existing and new account. I still don't see any message sent to my gmail or expensifail account. Maybe I'll try again in a bit? Not sure

melvin-bot[bot] commented 1 month ago

@Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!

Christinadobrzyn commented 1 month ago

Still not getting these messages - I tested again with an expensifail.com email.

@justinpersaud would you have any additional information on when an invite is sent? I'm not sure why I'm not getting these

Christinadobrzyn commented 1 month ago

sorry I haven't been able to test this again. I will test again tomorrow.

MelvinBot commented 1 month ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Christinadobrzyn commented 1 month ago

I still am not getting these chat room emails - not sure why. I'll see if QA is getting this so we can move this forward. https://expensify.slack.com/archives/C9YU7BX5M/p1721860004335859

Christinadobrzyn commented 1 month ago

QA is testing

Christinadobrzyn commented 1 month ago

checking with QA

m-natarajan commented 1 month ago

I am able to reproduce, I tested with public domain. Snip - #test-room - mnata utest@gmail com - Gmail - Google Chrome

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~01185310fddc87e53a

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

Christinadobrzyn commented 1 month ago

QA can reproduce so let's keep this rolling. adding external

dukenv0307 commented 1 month ago

@Christinadobrzyn I think this's BE bug

Christinadobrzyn commented 1 month ago

Ah thanks @dukenv0307 - added the internal label and I'll try to find someone to work on this

Christinadobrzyn commented 1 month ago

still looking for a volunteer

Christinadobrzyn commented 1 month ago

Since VIP-VSB is on hold - sounds like we're closing these.