[HOLD for payment 2024-08-14] [$250] Customers and Projects have option as `Sage Intacct Employee Default`

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @sakluger Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721402815163979

Action Performed:

Pre-testing requirement: Make sure that your test account is on the intacctOnNewExpensify beta

1. Open any workspace settings
2. Enable accounting
3. Connect to Intacct
4. Click on Import

Expected Result:

Customers and Projects dimensions should have Tag and Report field options only; Employee Default should not be an option

Actual Result:

Sage Intacct Employee Default shows as an option for Customers and Projects dimensions

NOTE: For me it projects is showing as Tags

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fea203f70b955c11
• Upwork Job ID: 1815806282266209115
• Last Price Increase: 2024-07-23

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot[bot]]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[stephanieelliott]

Updated the issue body to be a bit more clear -- the Customer and Project dimensions should show the Report Field and Tag options ONLY; Employee Default should not show as an option for these dimensions and needs to be removed.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01fea203f70b955c11

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Sage Intacct Employee Default shows as an option for Customers and Projects dimensions

What is the root cause of that problem?

After connecting to Sage intacct, BE returns Employee Default for Customer and Project

What changes do you think we should make in order to solve the problem?

1. We should fix BE to return Tags by default
2. In

https://github.com/Expensify/App/blob/2bb1d002b9dfa7045a5ddbcb7ee99d4ae207948d/src/pages/workspace/accounting/intacct/import/SageIntacctToggleMappingsPage.tsx#L95

We should change to CONST.SAGE_INTACCT_MAPPING_VALUE.TAG

Then remove employeeDefault in

https://github.com/Expensify/App/blob/2bb1d002b9dfa7045a5ddbcb7ee99d4ae207948d/src/pages/workspace/accounting/intacct/import/SageIntacctMappingsTypePage.tsx#L29-L35

We also can remove default mapping options in getDisplayTypeTranslationKey and getDisplayTypeTranslationKeys

What alternative solutions did you explore? (Optional)

NA

[jayeshmangwani]

Hey @dominictb 👋 , I have a hard time reaching this page.

Just a question: how can we reach this page and reproduce the issue?

[stephanieelliott]

@jayeshmangwani how far are you able to get on the repro steps -- are you able to reach Connect to Intacct? If not, you likely need to complete the pre-requisite steps described in https://github.com/Expensify/App/issues/45938#issue-2423611937, more specifically we need to add you to the intacctOnNewExpensify beta. If you can share the email address for the test account you're using, I can add you to that beta.

[jayeshmangwani]

more specifically we need to add you to the intacctOnNewExpensify beta. If you can share the email address for the test account you're using, I can add you to that beta.

Please add jm98289517+46@gmail.com , I will try to connect with this user

[SzymczakJ]

I was implementing this and Sage Intacct design doc didn't state anything like this, do we have a main source of truth?

[jayeshmangwani]

@SzymczakJ Currently, I don't have access to the Design doc. However, according to @sakluger's Issue Description:

According to the design doc and based on the OldDot config settings, Customer and Project dimensions do not support employee default, so those two dimensions should only have tag and report field options.

[SzymczakJ]

Sorry for the confusion, I should have read the whole thread before writing comments 😅. Can this issue be assigned as I already have context and I am author of this implementation?

[JmillsExpensify]

Assigned @SzymczakJ since he implemented this feature.

[hungvu193]

I'll review PR today 😄

[jayeshmangwani]

@stephanieelliott Please assign this issue to @hungvu193 as they reviewed the original PR that worked on this feature and have more context. I am unassigning myself.

[melvin-bot[bot]]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hungvu193]

@Gonals https://github.com/Expensify/App/pull/46505 will be ready for your final review

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.17-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/46505

If no regressions arise, payment will be issued on 2024-08-14. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @SzymczakJ does not require payment (Contractor)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@hungvu193] Determine if we should create a regression test for this bug.
• [ ] [@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot[bot]]

Payment Summary

Upwork Job

• Reviewer: @hungvu193 owed $250 via NewDot
• Contributor: @SzymczakJ is from an agency-contributor and not due payment

BugZero Checklist (@stephanieelliott)

• [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1815806282266209115/hired)
• [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [ ] I have verified the payment summary above is correct

[hungvu193]

@stephanieelliott No payment is needed for me. Feel free to close