Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[HOLD for payment 2024-08-14] [CRITICAL] [Advanced Approval Workflows] Enhance `toLocaleOrdinal` to support string ordinals #45958

Closed tgolen closed 2 months ago

tgolen commented 3 months ago

Coming from: #wave-control: advanced approval + workflows polish

Issue OwnerCurrent Issue Owner: @blazejkustra
blazejkustra commented 3 months ago

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

melvin-bot[bot] commented 3 months ago

@tgolen, @blazejkustra Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 3 months ago

@tgolen, @blazejkustra Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] commented 3 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 3 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.17-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-14. :confetti_ball:

For reference, here are some details about the assignees on this issue:

shubham1206agra commented 3 months ago

@tgolen Payment will be handled in another issue. https://github.com/Expensify/App/issues/45951

tgolen commented 3 months ago

OK, sounds good, thanks. I think this one will end up closing out automatically at some point.

melvin-bot[bot] commented 3 months ago

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

melvin-bot[bot] commented 2 months ago

@tgolen, @blazejkustra Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 2 months ago

@tgolen, @blazejkustra Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] commented 2 months ago

@tgolen, @blazejkustra Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

melvin-bot[bot] commented 2 months ago

@tgolen, @blazejkustra 12 days overdue now... This issue's end is nigh!

shubham1206agra commented 2 months ago

@tgolen Please close this issue.