[HOLD for Payment 2024-09-3][$125] Categorizing - Distance rate list is empty when workspace is non-existent during categorizing

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Account has no workspace
  1. Go to staging.new.expensify.com
  2. Go to self DM
  3. Track a distance expense
  4. Click Categorize it
  5. Select a category
  6. Proceed to confirmation page
  7. Click Rate on confirmation page

Expected Result:

Rate list should display the workspace distance rate

Actual Result:

Rate list is empty This issue only happens when there is no workspace in the account

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/a2975fb4-3b6a-42ca-8ba1-c4f9bfb30cdb

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b13e9e624d638835
• Upwork Job ID: 1818860377251381062
• Last Price Increase: 2024-08-30
• Automatic offers:
• dominictb | Contributor | 103403381

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot[bot]]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Rate list is empty This issue only happens when there is no workspace in the account

What is the root cause of that problem?

There're 2 problems:

1. We're getting rates from policy

https://github.com/Expensify/App/blob/c47208e8539085321183d6f9210b4220acd7cab4/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx#L118

It's not correct, since after users click categorize it, we just create the draft policy -> rates are undefined

2. In MoneyRequestConfirmationList we're getting mileageRates so it will be empty object

https://github.com/Expensify/App/blob/c47208e8539085321183d6f9210b4220acd7cab4/src/components/MoneyRequestConfirmationList.tsx#L909

What changes do you think we should make in order to solve the problem?

1. we should get the policyDraft and rateDrafts and get the actual policy/rates as what we already did in here

In IOURequestStepDistanceRate

    const policy = policyReal ?? policyDraft
    const rates = isEmpty(rates) ? rateDrafts : rates

... 
const IOURequestStepDistanceRateWithOnyx = withOnyx<IOURequestStepDistanceRateProps, IOURequestStepDistanceRateOnyxProps>({
...
export default withOnyx<MoneyRequestConfirmationListProps, MoneyRequestConfirmationListOnyxProps>({
...
    policyDraft: {
        key: ({reportDraft, transaction}) => `${ONYXKEYS.COLLECTION.POLICY_DRAFTS}${IOU.getIOURequestPolicyID(transaction, reportDraft)}`,
    },
    rateDrafts: {
        key: ({reportDraft, transaction}) => `${ONYXKEYS.COLLECTION.POLICY_DRAFTS}${IOU.getIOURequestPolicyID(transaction, reportDraft)}`,
        selector: (policy: OnyxEntry<Policy>) => DistanceRequestUtils.getMileageRates(policy),
    },

2. Get the draft mileageRates In MoneyRequestConfirmationList

    const mileageRates = isEmpty(mileageRatesReal) ? mileageRatesDraft: mileageRatesReal;
...

...
    mileageRatesDraft: {
        key: ({policyID}) => `${ONYXKEYS.COLLECTION.POLICY_DRAFTS}${policyID}`,
        selector: (policy: OnyxEntry<OnyxTypes.Policy>) => DistanceRequestUtils.getMileageRates(policy),
    },

What alternative solutions did you explore? (Optional)

NA

Result

https://github.com/user-attachments/assets/a8ea1516-d322-4d10-8f01-5f6d8786d1d8

[melvin-bot[bot]]

@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

@adelekennedy 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01b13e9e624d638835

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[allroundexperts]

@dominictb's proposal looks good to me. It has the correct RCA and the proposed solution works as well.

🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @tgolen, @allroundexperts, @adelekennedy, @dominictb eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[tgolen]

Monthly Update

• I think this is still trying to get finished up. The initial fix caused a regression that lead to the app crashing

Next Steps

• @tgolen wait a few more days to ensure the regression period has passed for the latest PR that fixed the crashing
• @tgolen bump this issue up to weekly priority so I don't forget about it next week
• @tgolen reduce pay by 50% for regression

ETA

• Closed out by Wednesday, Sep 4

[melvin-bot[bot]]

Upwork job price has been updated to $125

[ikevin127]

Coming from @tgolen's comment in https://github.com/Expensify/App/issues/47914#issuecomment-2321481090, since that issue was closed and ⚠️ automation did not kick in here for the 2nd (regression) PR which I reviewed as C+ and require payment for -> this should be on [HOLD for Payment 2024-09-3] according to 4 days ago production deploy from https://github.com/Expensify/App/pull/48016#issuecomment-2311254152.

cc @adelekennedy

[adelekennedy]

It sounds like the only payments due here are for the PR review from @ikevin127

[allroundexperts]

I think I might be eligible for half the payment since I reviewed the original PR.

[ikevin127]

cc @adelekennedy For payments today since the issue has Monthly label and might've got buried.

[ikevin127]

@adelekennedy Bump for payment 💸

[ikevin127]

@adelekennedy Bump for payment, day 3 🙈

[adelekennedy]

Payouts due:

• [ ] $125 @allroundexperts NewDot
• [x] $250 @ikevin127 Upwork

[ikevin127]

@adelekennedy Offer accepted, thank you! 💯

[dominictb]

Hi @adelekennedy, I'm also due payment here as I'm the assigned contributor who raised the PR for this issue.

Could you please take a look? 🙏