search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.31k stars 2.74k forks source link

[HOLD for payment 2024-08-09] [Payment card / Subscription] make 3DS modal close when authentication fails #46066

Closed blimpich closed 3 weeks ago

blimpich commented 1 month ago

Problem

When a user fails the SCA / 3DS authentication flow the modal doesn't close. This is slightly tricky to test since only expensify engineers can test this due to how the 3DS authentication flow works.

https://github.com/user-attachments/assets/f14994cc-e979-4b6b-ab1e-cc2e58c321b6

Solution

Make the modal close.

melvin-bot[bot] commented 1 month ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.15-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-09. :confetti_ball:

melvin-bot[bot] commented 1 month ago

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

melvin-bot[bot] commented 3 weeks ago

@blimpich Huh... This is 4 days overdue. Who can take care of this?

blimpich commented 3 weeks ago

This was deployed to production.