search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.31k stars 2.74k forks source link

[HOLD for payment 2024-08-05] [TS] Memoize utility instance lacks typings for cache property #46069

Closed kacper-mikolajczak closed 3 weeks ago

kacper-mikolajczak commented 1 month ago

Details

This is a known regression, which originates from https://github.com/Expensify/App/pull/43868

Instance of memoize module lacks correct typings for cache property. Methods of cache (get, set, etc.) have key parameter typed as unknown.

Steps to reproduce

  1. Create an instance of memoize by calling memoize method
  2. Check the typings of cache property methods on the instance

Expected behaviour

key argument in cache methods matches arguments of memoized function

Actual behaviour

key argument is set to unknown

Screenshot 2024-07-23 at 22 03 03
kacper-mikolajczak commented 1 month ago

I will work on this!

melvin-bot[bot] commented 1 month ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.13-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-05. :confetti_ball:

melvin-bot[bot] commented 1 month ago

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

kacper-mikolajczak commented 1 month ago

I think we can close this one, right @mountiny?

mountiny commented 3 weeks ago

Yep, thanks!