search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.35k stars 2.78k forks source link

Add a deploy confirmation step on web #46156

Closed roryabraham closed 1 month ago

roryabraham commented 2 months ago

Problem

Coming from here, we went a few days without noticing production deploys were broken.

Solution

We've addressed the root cause and I created https://github.com/rhysd/actionlint/issues/440 to try and prevent any similar type of error in the future.

However, let's also add an automated check that just confirms that the deploy completed as we expect, at least on web. In order to do this, we can just download the version.json file hosted on staging and/or production and verify that it matches what we expect after the deploy is done.

roryabraham commented 2 months ago

Thinking about this some more, even if we had this in place it would not have caught the error we had. Because the URL we were using was wrong for the upload, there's no reason to think it would've been right on the verification step. So I'm going to just close this actually.

roryabraham commented 2 months ago

if we wanted to do this, I think we'd want it to be a manual check. Not sure how we'd fit that in as a deployer responsibility though

roryabraham commented 2 months ago

we decided to add this after all

melvin-bot[bot] commented 2 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.13-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-05. :confetti_ball:

melvin-bot[bot] commented 1 month ago

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.