[Held requests] [$250] "Confirm approval amount modal" appears for the deleted held expense

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.11-5 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @puneetlath Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721855333504669

Action Performed:

1. Submit a report with 2 expenses
2. Sign in as a approver
3. Open the report
4. Put one expense on Hold
5. As a submitter delete the held expense
6. As approver click on "approve"

   Expected Result:

   Modal should not show with approval amount

   Actual Result:

   Confirm approval amount modal is shown

   Workaround:

   unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/ff48173f-1bbd-4b47-b773-bd81f6f9a09a

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011e21d9e5fefda11c
• Upwork Job ID: 1818028931528326795
• Last Price Increase: 2024-08-08
• Automatic offers:
• eh2077 | Reviewer | 103369133

Issue Owner

Current Issue Owner: @eh2077

[melvin-bot[bot]]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

@m-natarajan Can you please share the full reproduced video? I tried and after the submitter submitted the expense, they could not delete a transaction.

[sakluger]

@nkdengineer you wouldn't be able to delete submitted expenses, but if the approver puts one of the expenses on hold, you would be able to delete the held expense.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~011e21d9e5fefda11c

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[burczu]

Hi, I’m Bartek from Callstack and I would like to work on this issue.

[melvin-bot[bot]]

📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[burczu]

Ok, so I wasn't able to reproduce the issue - when I delete the held expense, it disappears on the approver side right away, and no modal shows up once I click the "Approve" button.

What concerns me @sakluger is that you wrote "if the approver puts one of the expenses on hold, you would be able to delete the held expense" in your previous comment - but I can only put the expense on hold as a submitter, not as an approver, so I suspect maybe I'm doing something wrong?

[melvin-bot[bot]]

@sakluger, @burczu, @eh2077 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[puneetlath]

Hm, yes the approver should be able to put the expense on hold. Do you have your workspace set up to have an approval turned on?

[eh2077]

Not overdue, discussion is ongoing

[burczu]

@puneetlath I think so:

[burczu]

Just to inform: I'll be ooo from tomorrow August 7th till the end of next week (August 18th).

[sakluger]

I think we can put this one on hold until you're back. @puneetlath if you think this is more time-sensitive, feel free to change back to daily and we can try recruiting someone else to work on it.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@sakluger @burczu @eh2077 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[puneetlath]

I'd say let's see if someone else can take it on.

[koko57]

@puneetlath ok, someone from our team will take it over

[narefyev91]

Hi, I’m Nicolay from Callstack and I would like to work on this issue. (will start investigation from Monday)

[trjExpensify]

Going to assign you @narefyev91!

[narefyev91]

@puneetlath @sakluger does issue still exist? Probably my tests on latest dev (maybe i did something wrong on videos, but generally following steps to reproduce): On safary - approval On chrome - submitter After approval marks expense as held, submitter removes expense, approval got removed that expense from the list. Approve button just approves rest of the expense(s)

https://github.com/user-attachments/assets/c60fb969-09e8-41db-9d93-02e426cedcf7

https://github.com/user-attachments/assets/cde85fdf-9300-4914-97ac-ebc2e874e850

[narefyev91]

Also based on debugging responses. When one expense is in hold - we get correctly status from API and will show modal to approve - because comment.hold is not empty

After removing we do not have that item in array any more:

[robertjchen]

Thanks for the investigation here! Having reviewed this, the issue appears to have already been resolved given that @burczu and @narefyev91 were unable to reproduce it

If you're still able to reproduce, let's create a fresh issue with an updated recording 👍