[HOLD for payment 2024-08-14] [$250] Onboarding – Keyboard not appears when Business name opens in "Manage my team expenses"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.12-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Issue found when executing PR https://github.com/Expensify/App/pull/45377

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with new Gmail account
3. Choose "Manage my team expenses" purpose on the first onboarding page
4. Verify Business name page opens

Expected Result:

Keyboard appears when Business name opens

Actual Result:

Keyboard not appears when Business name opens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/017a7344-18fb-404f-b251-74dcf56d1b48

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011303f7713569ea41
• Upwork Job ID: 1817906447482578584
• Last Price Increase: 2024-07-29

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot[bot]]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Keyboard not appears when Business name opens in "Manage my team expenses"

What is the root cause of that problem?

We don't set useAutoFocusInput ref to the input wrapper here

What changes do you think we should make in order to solve the problem?

set useAutoFocusInput ref to the input wrapper like here

const {inputCallbackRef} = useAutoFocusInput();

ref={inputCallbackRef}

What alternative solutions did you explore? (Optional)

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding – Keyboard does not show up when Business name page opens in "Manage my team expenses".

What is the root cause of that problem?

If the below focus method gets called before the transition is complete, then it is possible that the keyboard doesn't open.

https://github.com/Expensify/App/blob/904e95008af0b3ee156421c048570c064f090f01/src/components/TextInput/BaseTextInput/index.native.tsx#L110

What changes do you think we should make in order to solve the problem?

We should pass shouldDelayFocus as true in the below input field to ensure that the transition is complete before the input is focused.

https://github.com/Expensify/App/blob/904e95008af0b3ee156421c048570c064f090f01/src/pages/OnboardingWork/BaseOnboardingWork.tsx#L101-L112

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~011303f7713569ea41

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[rayane-djouah]

@nyomanjyotisa's proposal looks good to me

:ribbon::eyes::ribbon: C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[NikkiWines]

agreed! 👍

[melvin-bot[bot]]

❌ There was an error making the offer to @rayane-djouah for the Reviewer role. The BZ member will need to manually hire the contributor.

[melvin-bot[bot]]

❌ There was an error making the offer to @nyomanjyotisa for the Contributor role. The BZ member will need to manually hire the contributor.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.17-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/46803

If no regressions arise, payment will be issued on 2024-08-14. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @nyomanjyotisa requires payment (Needs manual offer from BZ)
• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@rayane-djouah] Determine if we should create a regression test for this bug.
• [ ] [@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot[bot]]

Payment Summary

Upwork Job

• ROLE: @nyomanjyotisa paid $(AMOUNT) via Upwork (LINK)
• ROLE: @rayane-djouah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@muttmuure)

• [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1817906447482578584/hired)
• [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [ ] I have verified the payment summary above is correct

[rayane-djouah]

• [x] The PR that introduced the bug has been identified. Link to the PR: This was implemented like this and not a regression.
• [x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [x] Determine if we should create a regression test for this bug. Yes
• [x] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

On mobile versions:

1. Create a new account
2. Choose "Manage my team expenses" purpose on the first onboarding page and click continue
3. Verify that the Business name page opens
4. Verify that the Keyboard appears automatically when the Business name page opens

[muttmuure]

$250 - @rayane-djouah $250 - @nyomanjyotisa

[muttmuure]

Invites sent to job, automation failed

[muttmuure]

job is here: https://www.upwork.com/jobs/~011303f7713569ea41

[rayane-djouah]

@muttmuure - Invite accepted, Thanks!

[nyomanjyotisa]

@muttmuure can't accept the invite, it says "This job is no longer available."

[muttmuure]

I've sent a new offer, could you try again?

[nyomanjyotisa]

Offer accepted

[rayane-djouah]

@muttmuure - Offer accepted. Thanks!

[muttmuure]

Paid