Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[$250] Expense - Unable to leave thread after the expense report changes to a thread #46193

Open lanitochka17 opened 1 month ago

lanitochka17 commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.12-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4764507 Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to DM with user that has no unsettled expense
  3. Submit an expense
  4. Click on the expense preview to go to expense report
  5. Send a message
  6. Click on the report header > Delete expense
  7. Delete the expense
  8. Click on the report header > Leave
  9. On the main chat, click on the # reply
  10. Note that Join button appears then disappears
  11. Click on the thread header
  12. Note that Leave button is still there after "leaving" the thread

Expected Result:

User will be able to leave the thread after deleting the expense

Actual Result:

User is unable to leave the thread after deleting the expense This issue only happens in expense report which turns to a normal message thread after deleting the expense It does not happen in regular message threads

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/371bf893-a65b-449d-a540-253559a3e2ce

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0117b2a90eba9471b7
  • Upwork Job ID: 1821193144429280011
  • Last Price Increase: 2024-08-07
Issue OwnerCurrent Issue Owner: @dukenv0307
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 1 month ago

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

melvin-bot[bot] commented 1 month ago

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 1 month ago

@JmillsExpensify Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] commented 1 month ago

@JmillsExpensify 10 days overdue. Is anyone even seeing these? Hello?

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~0117b2a90eba9471b7

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

JmillsExpensify commented 1 month ago

I'll add the external label to see if we have an easy fix, and this is technically part of split since it's an IOU issue.

dukenv0307 commented 1 month ago

@JmillsExpensify It's BE bug

melvin-bot[bot] commented 1 month ago

@JmillsExpensify @dukenv0307 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 1 month ago

@JmillsExpensify, @dukenv0307 Huh... This is 4 days overdue. Who can take care of this?

JmillsExpensify commented 1 month ago

BE bug so we're waiting on internal volunteers now.

melvin-bot[bot] commented 1 month ago

@JmillsExpensify, @dukenv0307 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] commented 1 month ago

@JmillsExpensify, @dukenv0307 10 days overdue. Is anyone even seeing these? Hello?

JmillsExpensify commented 4 weeks ago

Still waiting on internal volunteers.

melvin-bot[bot] commented 4 weeks ago

@JmillsExpensify, @dukenv0307 12 days overdue. Walking. Toward. The. Light...

melvin-bot[bot] commented 3 weeks ago

This issue has not been updated in over 14 days. @JmillsExpensify, @dukenv0307 eroding to Weekly issue.

melvin-bot[bot] commented 1 day ago

This issue has not been updated in over 15 days. @JmillsExpensify, @dukenv0307 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!