[$250] Expense - LHN shows RBR & report loads infinitely when invited member opens transaction thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.12-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. [User A] Submit two expenses to User B.
3. [User A] Go to transaction thread of any expense.
4. [User A] Send a user mention containing User C.
5. [User A] Click Invite from the whisper message.
6. [User A] Send a message in the transaction thread.
7. [User C] Click on the invited transaction thread in LHN.

Expected Result:

User C should be able to access the transaction thread as User C is an invited member

Actual Result:

The invited transaction thread appears in LHN, but shows RBR and infinite loading when trying to access it.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/8ef80203-5467-4df6-8fe2-357e5b11add9

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d8847daf9b5eef47
• Upwork Job ID: 1816586516522830387
• Last Price Increase: 2024-08-01

Issue Owner

Current Issue Owner: @marcochavezf

[melvin-bot[bot]]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[joekaufmanexpensify]

I can reproduce this. It isn't strictly limited to 1:1 DMs. If you try and invite someone into an expense in a workspace chat, it happens there too. Sharing a colleague onto a thread for an expense feels like something that could be reasonably common, so we should fix this.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01d8847daf9b5eef47

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[joekaufmanexpensify]

Pending proposals

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN shows RBR & report loads infinitely when invited member opens transaction thread

What is the root cause of that problem?

When we press the invite button we only remove the Concierge chat or resolve the alert message of inviting the member We didn't invite the user to our Workspace https://github.com/Expensify/App/blob/89539876835bc9ecb022f36f793d826a3def610e/src/pages/home/report/ReportActionItem.tsx#L482

What changes do you think we should make in order to solve the problem?

We can check if the report has a policy (workspace) we can invoke the addMembersToWorkspace function and pass the report.policyID value, else if it's a normal room we can invoke the inviteRoom function and also pass the reportID value

What alternative solutions did you explore? (Optional)

[melvin-bot[bot]]

@Pujan92, @joekaufmanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[joekaufmanexpensify]

@Pujan92 can you review the proposal here?

[Pujan92]

I will review it max by tomorrow.

[joekaufmanexpensify]

TY!

[Pujan92]

When we press the invite button we only remove the Concierge chat or resolve the alert message of inviting the member We didn't invite the user to our Workspace

@NJ-2020 We are making an API call for that resolution, So I believe the backend should handle this and allow user C to access this chat report. Right now accessing that report for User C gives 404(Report no longer exists).

--

@joekaufmanexpensify I suggest adding an engineering label to confirm.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[joekaufmanexpensify]

@Pujan92 Got it. Does that mean you think this issue will be an entirely backend fix?

[Pujan92]

Yes @joekaufmanexpensify

[joekaufmanexpensify]

Got it. The engineering label won't auto-assign someone. The only way to auto-assign an engineer to confirm that is if you do the C+ proposal selected message.

[melvin-bot[bot]]

📣 @shah-pujan! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

   Contributor details
   Your Expensify account email: <REPLACE EMAIL HERE>
   Upwork Profile Link: <REPLACE LINK HERE>

[Pujan92]

auto-assign an internal engineer to confirm the required change.

🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[blimpich]

I agree with @Pujan92, looks like a backend issue. I can't prioritize this issue so I'll unassign myself.

[joekaufmanexpensify]

Sounds good! Thanks for confirming

[joekaufmanexpensify]

Waiting for internal volunteer

[joekaufmanexpensify]

Moved to hotpicks as this needs an internal volunteer

[joekaufmanexpensify]

Pending internal volunteer

[melvin-bot[bot]]

@joekaufmanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[joekaufmanexpensify]

Still just waiting for internal prioritization

[joekaufmanexpensify]

Same

[joekaufmanexpensify]

Still pending an internal engineer

[joekaufmanexpensify]

Same

[joekaufmanexpensify]

Still pending someone picking this up

[joekaufmanexpensify]

Still looking for internal volunteer here

[joekaufmanexpensify]

Same

[joekaufmanexpensify]

One of three remaining collect hot picks. So this should get a volunteer soon!

[joekaufmanexpensify]

Going to be OOO from tomorrow - Monday. No need to add another BZ here as just waiting for someone internally to pick this up. I can handle anything that comes up when I am back.

[marcochavezf]

I wasn't able to reproduce the issue locally but created a WIP PR to update the report to read-only permissions per this convo

[trjExpensify]

Assigning @marcochavezf as he's working on this.

[joekaufmanexpensify]

Awesome. TY!

[marcochavezf]

PR in review

[joekaufmanexpensify]

Amazing. TY!

[joekaufmanexpensify]

Auth PR deployed, so closing this. Thanks again @marcochavezf