Closed lanitochka17 closed 1 week ago
Triggered auto assignment to @joekaufmanexpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
I can reproduce this. It isn't strictly limited to 1:1 DMs. If you try and invite someone into an expense in a workspace chat, it happens there too. Sharing a colleague onto a thread for an expense feels like something that could be reasonably common, so we should fix this.
Job added to Upwork: https://www.upwork.com/jobs/~01d8847daf9b5eef47
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External
)
Pending proposals
LHN shows RBR & report loads infinitely when invited member opens transaction thread
When we press the invite button we only remove the Concierge chat or resolve the alert message of inviting the member We didn't invite the user to our Workspace https://github.com/Expensify/App/blob/89539876835bc9ecb022f36f793d826a3def610e/src/pages/home/report/ReportActionItem.tsx#L482
We can check if the report has a policy (workspace) we can invoke the addMembersToWorkspace
function and pass the report.policyID
value, else if it's a normal room we can invoke the inviteRoom
function and also pass the reportID value
@Pujan92, @joekaufmanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
@Pujan92 can you review the proposal here?
I will review it max by tomorrow.
TY!
When we press the invite button we only remove the Concierge chat or resolve the alert message of inviting the member We didn't invite the user to our Workspace
@NJ-2020 We are making an API call for that resolution, So I believe the backend should handle this and allow user C to access this chat report. Right now accessing that report for User C gives 404(Report no longer exists).
--
@joekaufmanexpensify I suggest adding an engineering label to confirm.
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@Pujan92 Got it. Does that mean you think this issue will be an entirely backend fix?
Yes @joekaufmanexpensify
Got it. The engineering label won't auto-assign someone. The only way to auto-assign an engineer to confirm that is if you do the C+ proposal selected message.
📣 @shah-pujan! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
auto-assign an internal engineer to confirm the required change.
🎀👀🎀 C+ reviewed
Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
I agree with @Pujan92, looks like a backend issue. I can't prioritize this issue so I'll unassign myself.
Sounds good! Thanks for confirming
Waiting for internal volunteer
Moved to hotpicks as this needs an internal volunteer
Pending internal volunteer
@joekaufmanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Still just waiting for internal prioritization
Same
Still pending an internal engineer
Same
Still pending someone picking this up
Still looking for internal volunteer here
Same
One of three remaining collect hot picks. So this should get a volunteer soon!
Going to be OOO from tomorrow - Monday. No need to add another BZ here as just waiting for someone internally to pick this up. I can handle anything that comes up when I am back.
Assigning @marcochavezf as he's working on this.
Awesome. TY!
PR in review
Amazing. TY!
Auth PR deployed, so closing this. Thanks again @marcochavezf
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.12-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
User C should be able to access the transaction thread as User C is an invited member
Actual Result:
The invited transaction thread appears in LHN, but shows RBR and infinite loading when trying to access it.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/8ef80203-5467-4df6-8fe2-357e5b11add9
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @marcochavezf