Open anmurali opened 1 month ago
Job added to Upwork: https://www.upwork.com/jobs/~01a9b5735e8551a25a
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External
)
Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.
Triggered auto assignment to @kadiealexander (NewFeature
), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.
:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:
Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature
)
(we good here, Jon.. copy updates and shizz).
Replace Enable your wallet with Add personal bank account task during onboarding
New feature
We need update the enableWallet
task for both Get paid back by my employer
and Chat and split bills with friends
here and here with Add personal bank account
:
{
type: 'addBankAccount',
autoCompleted: false,
title: 'Add personal bank account',
description:
'You’ll need to add your personal bank account to get paid back. Don’t worry, it’s easy!\n' +
'\n' +
'Here’s how to set up your bank account:\n' +
'\n' +
'1. Click your profile picture.\n' +
'2. *Click Wallet* > *Bank accounts* > *+ Add bank account*.\n' +
'3. Connect your bank account.\n' +
'\n' +
'Once that’s done, you can request money from anyone and get paid back right into your personal bank account.',
},
RESULT
Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
📣 @nyomanjyotisa 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.15-9 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-09. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.16-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-13. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
No payments are due yet. The PR is reverted here https://github.com/Expensify/App/pull/46630.
We check the name of the onboarding tasks to create in Auth, and at the moment Auth doesn't expects any task called addBankAccount
cc @francoisl @Beamanator
Thank you sir, closing!
@Beamanator Should we keep the issue open and get the BE change?
Yes, this was reverted.
Oh merp my bad for not understanding 🙃 I'll let @tgolen do his thing here, I'll back away slowly..........
OK... so, I'm coming up to speed on this. It sounds like a backend change is necessary to support the front-end PR. Is anyone on that?
Doesn't look like anyone is on it, and the revert was because Auth expects the task name to match: https://github.com/Expensify/App/pull/46630#issue-2441277658
OK, thanks! Any volunteers to do the BE fix? I probably won't be able to get to it until the tail end of next week.
Assuming there are no volunteers, I will try to get to this later this week.
Yeah, that assumption is correct. Thanks, Tim!
@francoisl Would you mind pointing me to the right spot in Auth where this needs to be added? I'm not familiar with the flow at all so I'm not sure where to look.
Ah, cool. Thanks! That should get me started
Is this a new task or just replacing the existing enableWallet
task? :/
Replace enable wallet task.
Oh right, then it's easier, especially for step 3. I'd suggest making the change in multiple steps though:
TASK_ENABLE_WALLET
in Auth, deploy thathehe, @francoisl you know a lot about this. Are you sure you aren't the volunteer I was looking for? 😉 😉
If it can wait until mid next week sure, otherwise I don't think I'll have time until then.
OK, I'll see if I have time to get to it before then.
On Wed, Aug 14, 2024 at 3:43 PM Francois Laithier @.***> wrote:
If it can wait until mid next week sure, otherwise I don't think I'll have time until then.
— Reply to this email directly, view it on GitHub https://github.com/Expensify/App/issues/46231#issuecomment-2289966974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJMAB5SNOCT3OU4EIKUUN3ZRPFOHAVCNFSM6AAAAABLPHZJ2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBZHE3DMOJXGQ . You are receiving this because you were mentioned.Message ID: @.***>
@tgolen any further updates on this one? Thanks!
Yeah, the auth change was deployed 3 days ago so @nyomanjyotisa can go ahead and reimplement the frontend.
@tgolen, @mollfpr, @kadiealexander, @nyomanjyotisa Whoops! This issue is 2 days overdue. Let's get this updated quick!
@nyomanjyotisa Could you create the new PR? Thanks!
@nyomanjyotisa bump!
@mollfpr PR is ready for review, sorry for the delay 🙏
There are two intents
Get paid back by my employer
andChat and split bills with friends
where one of the onboading tasks we show isEnable your wallet
. But the wallet flow is onerous and we actually have not cleaned it up to show clear and actionable error messages and this is not a priority either till more people use IOU payments.So for now, let's replace this task with a
Add personal bank account
Title: Add personal bank account Description:
You’ll need to add your personal bank account to get paid back. Don’t worry, it’s easy! Here’s how to set up your bank account:
Once that’s done, you can request money from anyone and get paid back right into your personal bank account.
Upwork Automation - Do Not Edit